-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plot Hider does not support 1.18 yet #75
Comments
1.18 requires a build of ProtocolLib from Jenkins, yet using that version doesn't work either, but it throws a more helpful stacktrace: https://paste.gg/p/anonymous/aebf6895993d47c685b9fdc472b81aac |
I'm working on it, but I'm waiting for a ProtocolLib update (dmulloy2/ProtocolLib#1592). |
Most of the work is ready, although I don't guarantee to keep the support for versions before 1.16. No test build for now. |
Just made some tests, 1.13-1.15 are actually completely out of the scope with modern PS and PH (Java 17 + simply refuse to start). Starting from 1.16.5 to 1.19, it works like a charm! That said, PlotHider is also natively compiled with Java 17. @NotMyFault is it ok for you to follow the FAWE pattern and support only 1.16.5+ for modern PH versions (since PS is indicated 1.13+ on spigot page, I'm a bit annoyed 😅)? Reminder: A pr will be made asap, I'm still waiting for a ProtocolLib update for a clean code... If you want to help me debugging and finding out possible issues, please send me a message on Discord: |
+1 for dropping support pre 1.16.5 |
Server Implementation
Paper
Server Version
1.18.1
Describe the bug
The Plugin PlotHider Unfortunately does not work
I have the latest version: 5.1.1 on the P2 version V6.3.0
But it doesn't work.
It only throws an error when the banned player comes to the plot
To Reproduce
On the plot /p flag set hide true
or ban a player with /p deny
However, he sees the property and the built one unchanged and the error is displayed in the console
Expected behaviour
That property should not be visible
Screenshots / Videos
Error log (if applicable)
https://paste.gg/p/anonymous/f17e3141105e477cab472fc09d73f51f
Plot Debugpaste
https://athion.net/ISPaster/paste/view/61ee5b0b8cd84ecda5623aec8f59990e
PlotHider Version
PlotHider version 5.1.1-SNAPSHOT
Checklist
Anything else?
No response
The text was updated successfully, but these errors were encountered: