Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot Hider does not support 1.18 yet #75

Closed
2 tasks done
Hajatoby opened this issue Jan 14, 2022 · 6 comments · Fixed by #96
Closed
2 tasks done

Plot Hider does not support 1.18 yet #75

Hajatoby opened this issue Jan 14, 2022 · 6 comments · Fixed by #96
Labels
bug Something isn't working

Comments

@Hajatoby
Copy link

Server Implementation

Paper

Server Version

1.18.1

Describe the bug

The Plugin PlotHider Unfortunately does not work
I have the latest version: 5.1.1 on the P2 version V6.3.0
But it doesn't work.
It only throws an error when the banned player comes to the plot

To Reproduce

On the plot /p flag set hide true
or ban a player with /p deny
However, he sees the property and the built one unchanged and the error is displayed in the console

Expected behaviour

That property should not be visible

Screenshots / Videos

Screenshot_4

Error log (if applicable)

https://paste.gg/p/anonymous/f17e3141105e477cab472fc09d73f51f

Plot Debugpaste

https://athion.net/ISPaster/paste/view/61ee5b0b8cd84ecda5623aec8f59990e

PlotHider Version

PlotHider version 5.1.1-SNAPSHOT

Checklist

Anything else?

No response

@NotMyFault NotMyFault added bug Something isn't working and removed Requires Testing labels Jan 14, 2022
@NotMyFault
Copy link
Collaborator

1.18 requires a build of ProtocolLib from Jenkins, yet using that version doesn't work either, but it throws a more helpful stacktrace: https://paste.gg/p/anonymous/aebf6895993d47c685b9fdc472b81aac

@NotMyFault NotMyFault changed the title Plot Hider not working Plot Hider does not support 1.18 yet Jan 26, 2022
@TomLewis
Copy link

@Aurelien30000
Copy link
Member

I'm working on it, but I'm waiting for a ProtocolLib update (dmulloy2/ProtocolLib#1592).

@Aurelien30000
Copy link
Member

Most of the work is ready, although I don't guarantee to keep the support for versions before 1.16. No test build for now.
A pull request will be opened asap.

@Aurelien30000
Copy link
Member

Aurelien30000 commented Jun 22, 2022

Just made some tests, 1.13-1.15 are actually completely out of the scope with modern PS and PH (Java 17 + simply refuse to start). Starting from 1.16.5 to 1.19, it works like a charm!

That said, PlotHider is also natively compiled with Java 17. @NotMyFault is it ok for you to follow the FAWE pattern and support only 1.16.5+ for modern PH versions (since PS is indicated 1.13+ on spigot page, I'm a bit annoyed 😅)?

Reminder: A pr will be made asap, I'm still waiting for a ProtocolLib update for a clean code...

If you want to help me debugging and finding out possible issues, please send me a message on Discord: ◀ λųгέłɪεŋ ▶#0101

@NotMyFault
Copy link
Collaborator

+1 for dropping support pre 1.16.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants