Fix: disable sign-coloring when edit-sign flag is false

[Tamikaschu]

Overview

Fixes #4247

Description

#4236 Adds sign coloring to edit-sign flag separately from the use flag. The use flag is typically used to allow interactions with shops etc, but players should not be able to just color every sign if the use flag is needed.

[PierreSchwang]

Generally a good addition, but maybe this code may utilize ItemTags, kind of like:

final org.bukkit.Tag<Material> dyesTag = Bukkit.getTag(org.bukkit.Tag.REGISTRY_ITEMS, NamespacedKey.minecraft("dyes"), Material.class);
if (dyesTag.isTagged(itemStack.getMaterial())) {
    // Interact with dye
}

I haven't been able to test that, nor do I know or found any information on when the dyes tag was introduced. If that works in all supported versions, it may be a more future proof solution and does not potentially break with new dyes added.

[Tamikaschu]

I will test it out but we have to keep in mind that not only dyes but also Honeycombs and Glow Ink Sack can be applied on signs. Will they also have the dye tag?

[PierreSchwang]

Yeah, forget what I said. Seems like my online source listed that as a item tag, but scavenging through the paper / minecraft 1.20.2 source does not contain such tag nor is there any other kind of tag to be respected in those Items or general sign manipulation.

[dordsor21]

Is there potentially a better event to use here rather than cancelling the interact? The block changes state so presumably that'll fire an event

[Tamikaschu]

Did some research and asked around on PaperMC discord. It seems that there is no good alternative event to detect players applying dye to signs or waxing them apart from PlayerInteractEvent. Sign coloring was added 1.16 and waxing 1.19. Should that maybe be checked in two separat events for the versions?

[dordsor21]

Did some research and asked around on PaperMC discord. It seems that there is no good alternative event to detect players applying dye to signs or waxing them apart from PlayerInteractEvent. Sign coloring was added 1.16 and waxing 1.19. Should that maybe be checked in two separat events for the versions?

Were any of the items added posted 1.16? If so it will need to done using strings as older servers will not have the Materials and so it will cause issues. No need for separate events though

[Tamikaschu]

Were any of the items added posted 1.16? If so it will need to done using strings as older servers will not have the Materials and so it will cause issues. No need for separate events though

Glow Ink Sac was added in 1.17. But if we would cancel PlayerInteractEvent when a player applies honey to a sign in versions below 1.20 it would cancel the Interact even though waxing is not even possible due to the version. Separating events would also allow some fine adjustment: we don't have to cancel interact when a sign is already waxed.

[dordsor21]

In that case just have a version check when building the list of items and only add depending of version. No need to do that for "new" items though as it's all strings

[SirYwell]

Looks good, thanks.