Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: MultiTaskLitModule Refactor #225

Open
1 of 6 tasks
melo-gonzo opened this issue May 24, 2024 · 0 comments
Open
1 of 6 tasks

[Feature request]: MultiTaskLitModule Refactor #225

melo-gonzo opened this issue May 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@melo-gonzo
Copy link
Collaborator

Feature/behavior summary

As it stands, the MultiTaskLitModule can be difficult to work with and is fragile. A refactor could help to resolve some issues, as well as introduce more functionality, modularity, and overall quality of life improvements when working with the module. As this would be a more involved refactor, collecting pros/cons of the current setup and ideas for improvement in this issue would be ideal to get a bird's eye view of the task at hand.

Request attributes

  • Would this be a refactor of existing code?
  • Does this proposal require new package dependencies?
  • Would this change break backwards compatibility?
  • Does this proposal include a new model?
  • Does this proposal include a new dataset?
  • Does this proposal include a new task/workflow?

Related issues

No response

Solution description

The resolution to most of the discussion points may still be unknown, and this is primarily intended as a source of discussion, brainstorming, and idea collating.

(In no particular order)

  • Pass only one encoder config, and generate output heads.
  • Remove unused code (e.g. the forward pass, self.encoder attribute, etc.).
  • Calculate loss and do backprop only if the optimizers associated dataset / task head had data processed. (see similar SAM Callback Update - Check If Optimizer Is Utilized #193)
  • Unify or make clear the processing pipelines for multi vs. single data.
  • Accept any arbitrary combination of dataset-task combinations

Additional notes

No response

@melo-gonzo melo-gonzo added the enhancement New feature or request label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant