Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-11561] Add onDimissHandler API #868

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

[MOB-11561] Add onDimissHandler API #868

wants to merge 16 commits into from

Conversation

TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Dec 28, 2022 •
edited
Loading

Description of the change

The old BugReporting.onSDKDismissedHandler used to have wrong types in the callback as mentioned in #620.
This PR introduces a new API called BugReporting.onDimissHandler that has the correct enum types.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN self-assigned this Dec 28, 2022
@TheBuggedYRN TheBuggedYRN linked an issue Dec 28, 2022 that may be closed by this pull request
onSDKDismissedHandler wrong callback arguments values #620
Open
Base automatically changed from dev to master December 29, 2022 13:27
@TheBuggedYRN TheBuggedYRN changed the base branch from master to dev January 12, 2023 10:10
@TheBuggedYRN TheBuggedYRN force-pushed the feat/on-dismiss-handler branch from 9f02315 to ff3226c Compare January 12, 2023 15:19
@TheBuggedYRN TheBuggedYRN changed the title [MOB-xxxx] Add onDimissHandler API [MOB-11561] Add onDimissHandler API Jan 12, 2023
@TheBuggedYRN TheBuggedYRN marked this pull request as ready for review January 12, 2023 15:24
@TheBuggedYRN TheBuggedYRN force-pushed the feat/on-dismiss-handler branch 2 times, most recently from 32c3ce9 to d29ced4 Compare January 13, 2023 15:26
@TheBuggedYRN TheBuggedYRN added the pending-ios Waiting for iOS release label Jan 15, 2023
@TheBuggedYRN TheBuggedYRN force-pushed the feat/on-dismiss-handler branch from 75420d3 to 6cd77d1 Compare February 8, 2023 09:55
Base automatically changed from dev to master February 20, 2023 14:52
@stale
Copy link

stale bot commented Feb 27, 2023

This issue has been automatically marked as pending feedback because we need additional information to be able to investigate it further. It will be closed in 7 days if it remains inactive. Thank you for your contributions.

@TheBuggedYRN TheBuggedYRN added WIP Work In Progress and removed Pending Feedback labels Feb 28, 2023
a7medev and others added 13 commits March 2, 2023 10:38
@a7medev
[MOB-12033] Restructure native Directory (#933)
ec1f130 
* Restructure Native Directory

* Remove commented code

* Fix imports in mocks
@a7medev
[MOB-9962] Migrate to NativeEventEmitter (#924)
0f48f89 
* Migrate the current IBGEventEmitter which uses the old NativeAppEventEmitter and DeviceEventEmitter to the new NativeEventEmitter which requires each module to have its own event emitter so the way we use emitter got restructured.

* Eliminate NetworkLogger's event emitters usage by using callbacks.
@TheBuggedYRN
[MOB-12043] Remove Android Module Dead Code (#884)
102ddc3
@TheBuggedYRN
[MOB-11997] Replace CLI dir flag with file (#937)
752b924
@TheBuggedYRN
[MOB-12070] Disable Sorucemaps Scripts on CI (#940)
06d364c 
The upload scripts used to run while running both Unit and E2E CI jobs,
resulting in more redundant time or unintended behavior.

These scripts were disabled by:
 1. Android: passing the `instabugUploadEnable` gradle property.
 2. iOS: setting the `INSTABUG_SOURCEMAPS_UPLOAD_DISABLE` environment variable.
@DavidMina96
Run probot-stale only on issues (#941)
a282b40
@TheBuggedYRN
[MOB-12143] Use circleci/ruby Image for Danger (#944)
07309e4 
The old dantoml/danger:latest is updated 4 years ago,
which makes it an obsolete image that lacks a lot of version upgrades.
@TheBuggedYRN
[MOB-12052] Use Shallow Checkout in CI (#943)
0067537 
The checkout step used to take around a minute 
due to the size of the repo (1 GB). With shallow
checkouts, it gets down to one second.
@TheBuggedYRN
[MOB-12050] Cache CI Pods (#945)
007a3bb
@TheBuggedYRN
[MOB-12180] Remove Redundant CI Steps (#947)
d8003a8
@TheBuggedYRN
Add onDismissHandler API to BugReporting
7fa9a38
@TheBuggedYRN
Rename native method
1658e6f
@TheBuggedYRN
Fix Android Test
e2e3663
@TheBuggedYRN TheBuggedYRN force-pushed the feat/on-dismiss-handler branch from 6cd77d1 to 97eac9e Compare March 16, 2023 13:47
@TheBuggedYRN TheBuggedYRN changed the base branch from master to dev March 16, 2023 13:47
@InstabugCI
Copy link
Collaborator

1 Warning
⚠️ You have not included a CHANGELOG entry!
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

Base automatically changed from dev to master April 20, 2023 09:36
@a7medev a7medev changed the base branch from master to dev May 26, 2023 07:00
Base automatically changed from dev to master May 30, 2023 13:06
@abdelhamid-f-nasser abdelhamid-f-nasser marked this pull request as draft December 13, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMina96 DavidMina96 Awaiting requested review from DavidMina96

At least 1 approving review is required to merge this pull request.

Assignees

@TheBuggedYRN TheBuggedYRN

Labels
pending-ios Waiting for iOS release WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onSDKDismissedHandler wrong callback arguments values
4 participants
@TheBuggedYRN @InstabugCI @a7medev @DavidMina96