From acb725ad7d5c9ded4940a3a88631c4bd8762aad0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20Haitz=20Legarreta=20Gorro=C3=B1o?= Date: Sun, 2 Feb 2025 12:48:51 -0500 Subject: [PATCH 1/6] STYLE: Use `ITK_TRY_EXPECT_NO_EXCEPTION` macro in `ImageCompose` tests Use `ITK_TRY_EXPECT_NO_EXCEPTION` macro in `ImageCompose` tests: - Use `ITK_TRY_EXPECT_NO_EXCEPTION` macro when updating filters in lieu of `try/catch` blocks for the sake of readability and compactness, and to save typing/avoid boilerplate code. - Only place with the macro the code that might raise exceptions. --- ...ompose2DCovariantVectorImageFilterTest.cxx | 13 +-- .../itkCompose2DVectorImageFilterTest.cxx | 12 +- ...ompose3DCovariantVectorImageFilterTest.cxx | 13 +-- .../itkCompose3DVectorImageFilterTest.cxx | 12 +- .../test/itkComposeRGBAImageFilterTest.cxx | 110 ++++++++---------- .../test/itkComposeRGBImageFilterTest.cxx | 13 +-- ...geReadRealAndImaginaryWriteComplexTest.cxx | 14 +-- .../test/itkImageToVectorImageFilterTest.cxx | 16 +-- .../itkJoinSeriesImageFilterStreamingTest.cxx | 11 +- 9 files changed, 70 insertions(+), 144 deletions(-) diff --git a/Modules/Filtering/ImageCompose/test/itkCompose2DCovariantVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkCompose2DCovariantVectorImageFilterTest.cxx index 8a58d45cc0e..69f31b500da 100644 --- a/Modules/Filtering/ImageCompose/test/itkCompose2DCovariantVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkCompose2DCovariantVectorImageFilterTest.cxx @@ -19,6 +19,7 @@ #include #include "itkComposeImageFilter.h" #include "itkMath.h" +#include "itkTestingMacros.h" int itkCompose2DCovariantVectorImageFilterTest(int, char *[]) @@ -63,17 +64,7 @@ itkCompose2DCovariantVectorImageFilterTest(int, char *[]) filter->SetInput1(zeroImage); filter->SetInput2(oneImage); - try - { - filter->Update(); - } - - catch (const itk::ExceptionObject & excp) - { - std::cerr << "Exception caught !" << std::endl; - std::cerr << excp << std::endl; - return EXIT_FAILURE; - } + ITK_TRY_EXPECT_NO_EXCEPTION(filter->Update()); using OutputImageType = FilterType::OutputImageType; diff --git a/Modules/Filtering/ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx index 97c32885df7..1712207389b 100644 --- a/Modules/Filtering/ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx @@ -19,6 +19,7 @@ #include #include "itkComposeImageFilter.h" #include "itkMath.h" +#include "itkTestingMacros.h" int itkCompose2DVectorImageFilterTest(int, char *[]) @@ -63,16 +64,7 @@ itkCompose2DVectorImageFilterTest(int, char *[]) filter->SetInput1(zeroImage); filter->SetInput2(oneImage); - try - { - filter->Update(); - } - catch (const itk::ExceptionObject & excp) - { - std::cerr << "Exception caught !" << std::endl; - std::cerr << excp << std::endl; - return EXIT_FAILURE; - } + ITK_TRY_EXPECT_NO_EXCEPTION(filter->Update()); using OutputImageType = FilterType::OutputImageType; diff --git a/Modules/Filtering/ImageCompose/test/itkCompose3DCovariantVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkCompose3DCovariantVectorImageFilterTest.cxx index 4741669b11f..64d07a6da46 100644 --- a/Modules/Filtering/ImageCompose/test/itkCompose3DCovariantVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkCompose3DCovariantVectorImageFilterTest.cxx @@ -19,6 +19,7 @@ #include #include "itkComposeImageFilter.h" #include "itkMath.h" +#include "itkTestingMacros.h" int itkCompose3DCovariantVectorImageFilterTest(int, char *[]) @@ -69,17 +70,7 @@ itkCompose3DCovariantVectorImageFilterTest(int, char *[]) filter->SetInput2(oneImage); filter->SetInput3(twoImage); - try - { - filter->Update(); - } - - catch (const itk::ExceptionObject & excp) - { - std::cerr << "Exception caught !" << std::endl; - std::cerr << excp << std::endl; - return EXIT_FAILURE; - } + ITK_TRY_EXPECT_NO_EXCEPTION(filter->Update()); using OutputImageType = FilterType::OutputImageType; diff --git a/Modules/Filtering/ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx index c979d8e6c6a..60cd45d17c2 100644 --- a/Modules/Filtering/ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx @@ -19,6 +19,7 @@ #include #include "itkComposeImageFilter.h" #include "itkMath.h" +#include "itkTestingMacros.h" int itkCompose3DVectorImageFilterTest(int, char *[]) @@ -68,16 +69,7 @@ itkCompose3DVectorImageFilterTest(int, char *[]) filter->SetInput2(oneImage); filter->SetInput3(twoImage); - try - { - filter->Update(); - } - catch (const itk::ExceptionObject & excp) - { - std::cerr << "Exception caught !" << std::endl; - std::cerr << excp << std::endl; - return EXIT_FAILURE; - } + ITK_TRY_EXPECT_NO_EXCEPTION(filter->Update()); using OutputImageType = FilterType::OutputImageType; diff --git a/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx index b8b24b08936..0fd0ce9fbfc 100644 --- a/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx @@ -37,73 +37,65 @@ itkComposeRGBAImageFilterTest(int argc, char * argv[]) << std::endl; } - try - { - // ARGUMENTS: - // argv[0] = Executable name - // argv[1] = Output file name and path - // argv[2] = Input 1 file name and path - // argv[2] = Input 2 file name and path - // argv[2] = Input 3 file name and path - // argv[2] = Input 4 file name and path + // ARGUMENTS: + // argv[0] = Executable name + // argv[1] = Output file name and path + // argv[2] = Input 1 file name and path + // argv[2] = Input 2 file name and path + // argv[2] = Input 3 file name and path + // argv[2] = Input 4 file name and path - // Get arguments - char * OutputFilename = argv[1]; - char * Input1Filename = argv[2]; - char * Input2Filename = argv[3]; - char * Input3Filename = argv[4]; - char * Input4Filename = argv[5]; + // Get arguments + char * OutputFilename = argv[1]; + char * Input1Filename = argv[2]; + char * Input2Filename = argv[3]; + char * Input3Filename = argv[4]; + char * Input4Filename = argv[5]; - // Typedefs - using ScalarPixelType = unsigned char; - constexpr unsigned int Dimension = 2; - using RGBAPixelType = itk::RGBAPixel; - using ScalarImageType = itk::Image; - using RGBAImageType = itk::Image; - using ReaderType = itk::ImageFileReader; - using WriterType = itk::ImageFileWriter; - using ComposeFilterType = itk::ComposeImageFilter; + // Typedefs + using ScalarPixelType = unsigned char; + constexpr unsigned int Dimension = 2; + using RGBAPixelType = itk::RGBAPixel; + using ScalarImageType = itk::Image; + using RGBAImageType = itk::Image; + using ReaderType = itk::ImageFileReader; + using WriterType = itk::ImageFileWriter; + using ComposeFilterType = itk::ComposeImageFilter; - // Read input1 - auto reader1 = ReaderType::New(); - reader1->SetFileName(Input1Filename); - reader1->Update(); + // Read input1 + auto reader1 = ReaderType::New(); + reader1->SetFileName(Input1Filename); + reader1->Update(); - // Read input2 - auto reader2 = ReaderType::New(); - reader2->SetFileName(Input2Filename); - reader2->Update(); + // Read input2 + auto reader2 = ReaderType::New(); + reader2->SetFileName(Input2Filename); + reader2->Update(); - // Read input3 - auto reader3 = ReaderType::New(); - reader3->SetFileName(Input3Filename); - reader3->Update(); + // Read input3 + auto reader3 = ReaderType::New(); + reader3->SetFileName(Input3Filename); + reader3->Update(); - // Read input4 - auto reader4 = ReaderType::New(); - reader4->SetFileName(Input4Filename); - reader4->Update(); + // Read input4 + auto reader4 = ReaderType::New(); + reader4->SetFileName(Input4Filename); + reader4->Update(); - // Test ComposeRGBA filter - auto filterCompose = ComposeFilterType::New(); - filterCompose->SetInput(0, reader1->GetOutput()); - filterCompose->SetInput(1, reader2->GetOutput()); - filterCompose->SetInput(2, reader3->GetOutput()); - filterCompose->SetInput(3, reader4->GetOutput()); - filterCompose->Update(); + // Test ComposeRGBA filter + auto filterCompose = ComposeFilterType::New(); + filterCompose->SetInput(0, reader1->GetOutput()); + filterCompose->SetInput(1, reader2->GetOutput()); + filterCompose->SetInput(2, reader3->GetOutput()); + filterCompose->SetInput(3, reader4->GetOutput()); - // Write output - auto writer = WriterType::New(); - writer->SetFileName(OutputFilename); - writer->SetInput(filterCompose->GetOutput()); - writer->Update(); - } - catch (const itk::ExceptionObject & err) - { - std::cerr << "ExceptionObject caught !" << std::endl; - std::cerr << err << std::endl; - return EXIT_FAILURE; - } + ITK_TRY_EXPECT_NO_EXCEPTION(filterCompose->Update()); + + // Write output + auto writer = WriterType::New(); + writer->SetFileName(OutputFilename); + writer->SetInput(filterCompose->GetOutput()); + writer->Update(); // Return return EXIT_SUCCESS; diff --git a/Modules/Filtering/ImageCompose/test/itkComposeRGBImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkComposeRGBImageFilterTest.cxx index b54eaf69919..6cb35f31204 100644 --- a/Modules/Filtering/ImageCompose/test/itkComposeRGBImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkComposeRGBImageFilterTest.cxx @@ -19,6 +19,7 @@ #include #include "itkRGBPixel.h" #include "itkComposeImageFilter.h" +#include "itkTestingMacros.h" int itkComposeRGBImageFilterTest(int, char *[]) @@ -69,17 +70,7 @@ itkComposeRGBImageFilterTest(int, char *[]) filter->SetInput2(greenImage); filter->SetInput3(blueImage); - try - { - filter->Update(); - } - - catch (const itk::ExceptionObject & excp) - { - std::cerr << "Exception caught !" << std::endl; - std::cerr << excp << std::endl; - return EXIT_FAILURE; - } + ITK_TRY_EXPECT_NO_EXCEPTION(filter->Update()); const OutputImageType::Pointer rgbImage = filter->GetOutput(); diff --git a/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx b/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx index 86ed21be425..85dd0ea4829 100644 --- a/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx @@ -73,18 +73,10 @@ itkImageReadRealAndImaginaryWriteComplexTest(int argc, char * argv[]) RealAndImaginary2Complex->SetInput1(readerReal->GetOutput()); RealAndImaginary2Complex->SetInput2(readerImag->GetOutput()); - writer->SetInput(RealAndImaginary2Complex->GetOutput()); + ITK_TRY_EXPECT_NO_EXCEPTION(RealAndImaginary2Complex->Update()); - try - { - writer->Update(); - } - catch (const itk::ExceptionObject & excp) - { - std::cerr << "Error writing the magnitude image: " << std::endl; - std::cerr << excp << std::endl; - return EXIT_FAILURE; - } + writer->SetInput(RealAndImaginary2Complex->GetOutput()); + writer->Update(); // check that the default template parameters work using DefaultParametersFilterType = itk::ComposeImageFilter; diff --git a/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx index 92450c0d64d..ec97b332556 100644 --- a/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx @@ -53,20 +53,14 @@ itkImageToVectorImageFilterTest(int argc, char * argv[]) filter->SetInput(f++, reader->GetOutput()); } + ITK_TRY_EXPECT_NO_EXCEPTION(filter->Update()); + auto writer = WriterType::New(); writer->SetFileName(argv[argc - 1]); + writer->SetInput(filter->GetOutput()); + writer->Update(); + - try - { - writer->SetInput(filter->GetOutput()); - writer->Update(); - } - catch (const itk::ExceptionObject & excp) - { - std::cerr << "Error while writing the file" << std::endl; - std::cerr << excp << std::endl; - return EXIT_FAILURE; - } std::cout << "Test passed." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx index 30c4b3fc209..f190ed7c03e 100644 --- a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx @@ -95,16 +95,7 @@ itkJoinSeriesImageFilterStreamingTest(int argc, char * argv[]) writer->SetFileName(outputFileName); writer->SetNumberOfStreamDivisions(numberOfSlices); - - try - { - writer->Update(); - } - catch (...) - { - std::cerr << "Exception while trying to stream write file." << std::endl; - throw; - } + ITK_TRY_EXPECT_NO_EXCEPTION(writer->Update()); std::cout << "Number of Updates: " << monitor1->GetNumberOfUpdates() << std::endl; std::cout << "Verifying ImageFileReader to ExtractImageFilter pipeline interaction" << std::endl; From f24dbb29cea41f3c47db41fbeb064fd1ba31dfdf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20Haitz=20Legarreta=20Gorro=C3=B1o?= Date: Sun, 2 Feb 2025 13:02:05 -0500 Subject: [PATCH 2/6] STYLE: Conform to ITK style guidelines in test ending message Conform to ITK style guidelines in test ending message across the `ImageCompose` module test files: add it where missing and use the same message consistently. Take advantage of the commit to remove unnecessary comments about objects being destroyed when exiting the test main method. --- .../test/itkCompose2DCovariantVectorImageFilterTest.cxx | 3 +-- .../ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx | 3 +-- .../test/itkCompose3DCovariantVectorImageFilterTest.cxx | 3 +-- .../ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx | 3 +-- .../ImageCompose/test/itkComposeRGBAImageFilterTest.cxx | 2 +- .../ImageCompose/test/itkComposeRGBImageFilterTest.cxx | 3 +-- .../test/itkImageReadRealAndImaginaryWriteComplexTest.cxx | 2 ++ .../ImageCompose/test/itkImageToVectorImageFilterTest.cxx | 2 +- Modules/Filtering/ImageCompose/test/itkJoinImageFilterTest.cxx | 2 +- .../test/itkJoinSeriesImageFilterStreamingTest.cxx | 1 + .../ImageCompose/test/itkJoinSeriesImageFilterTest.cxx | 2 +- 11 files changed, 12 insertions(+), 14 deletions(-) diff --git a/Modules/Filtering/ImageCompose/test/itkCompose2DCovariantVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkCompose2DCovariantVectorImageFilterTest.cxx index 69f31b500da..89c03be7b45 100644 --- a/Modules/Filtering/ImageCompose/test/itkCompose2DCovariantVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkCompose2DCovariantVectorImageFilterTest.cxx @@ -103,7 +103,6 @@ itkCompose2DCovariantVectorImageFilterTest(int, char *[]) ++i1; } - std::cout << "Test Passed !" << std::endl; - + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx index 1712207389b..47ac23eb21d 100644 --- a/Modules/Filtering/ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkCompose2DVectorImageFilterTest.cxx @@ -103,7 +103,6 @@ itkCompose2DVectorImageFilterTest(int, char *[]) ++i1; } - std::cout << "Test Passed !" << std::endl; - + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkCompose3DCovariantVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkCompose3DCovariantVectorImageFilterTest.cxx index 64d07a6da46..829acba7f8a 100644 --- a/Modules/Filtering/ImageCompose/test/itkCompose3DCovariantVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkCompose3DCovariantVectorImageFilterTest.cxx @@ -117,7 +117,6 @@ itkCompose3DCovariantVectorImageFilterTest(int, char *[]) ++i2; } - std::cout << "Test Passed !" << std::endl; - + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx index 60cd45d17c2..0193c54dbe9 100644 --- a/Modules/Filtering/ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkCompose3DVectorImageFilterTest.cxx @@ -116,7 +116,6 @@ itkCompose3DVectorImageFilterTest(int, char *[]) ++i2; } - std::cout << "Test Passed !" << std::endl; - + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx index 0fd0ce9fbfc..aa18b143c6f 100644 --- a/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx @@ -97,6 +97,6 @@ itkComposeRGBAImageFilterTest(int argc, char * argv[]) writer->SetInput(filterCompose->GetOutput()); writer->Update(); - // Return + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkComposeRGBImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkComposeRGBImageFilterTest.cxx index 6cb35f31204..59560971762 100644 --- a/Modules/Filtering/ImageCompose/test/itkComposeRGBImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkComposeRGBImageFilterTest.cxx @@ -115,7 +115,6 @@ itkComposeRGBImageFilterTest(int, char *[]) ++ib; } - std::cout << "Test Passed !" << std::endl; - + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx b/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx index 85dd0ea4829..d43047d4bf2 100644 --- a/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx @@ -85,5 +85,7 @@ itkImageReadRealAndImaginaryWriteComplexTest(int argc, char * argv[]) { return EXIT_FAILURE; } + + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx index ec97b332556..536896a8474 100644 --- a/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx @@ -61,6 +61,6 @@ itkImageToVectorImageFilterTest(int argc, char * argv[]) writer->Update(); - std::cout << "Test passed." << std::endl; + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkJoinImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkJoinImageFilterTest.cxx index 09c0388ea41..03d534610f2 100644 --- a/Modules/Filtering/ImageCompose/test/itkJoinImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkJoinImageFilterTest.cxx @@ -252,6 +252,6 @@ itkJoinImageFilterTest(int, char *[]) } - // All objects should be automatically destroyed at this point + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx index f190ed7c03e..e5cc092483e 100644 --- a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx @@ -116,5 +116,6 @@ itkJoinSeriesImageFilterStreamingTest(int argc, char * argv[]) return EXIT_FAILURE; } + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } diff --git a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterTest.cxx index cbd9707bc27..04fa5de8b50 100644 --- a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterTest.cxx @@ -224,6 +224,6 @@ itkJoinSeriesImageFilterTest(int, char *[]) } - std::cout << "Test passed." << std::endl; + std::cout << "Test finished." << std::endl; return EXIT_SUCCESS; } From a2ea1b82939e234887cdcfc4689a43625b35367c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20Haitz=20Legarreta=20Gorro=C3=B1o?= Date: Sun, 2 Feb 2025 13:05:21 -0500 Subject: [PATCH 3/6] STYLE: Conform to ITK style guidelines in test arg check message Conform to ITK style guidelines in test argument check message across the `ImageCompose` module test files: add the missing argument message where missing and use the same message consistently. --- .../ImageCompose/test/itkComposeRGBAImageFilterTest.cxx | 2 +- .../test/itkImageReadRealAndImaginaryWriteComplexTest.cxx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx index aa18b143c6f..f0789ff44b6 100644 --- a/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx @@ -31,7 +31,7 @@ itkComposeRGBAImageFilterTest(int argc, char * argv[]) if (argc < 6) { - std::cerr << "Error: missing arguments" << std::endl; + std::cerr << "Missing parameters." << std::endl; std::cerr << "Usage: " << std::endl; std::cerr << itkNameOfTestExecutableMacro(argv) << " outputFile inputFileR inputFileG inputFileB inputFileA" << std::endl; diff --git a/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx b/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx index d43047d4bf2..2b2ada8f894 100644 --- a/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx @@ -40,6 +40,7 @@ itkImageReadRealAndImaginaryWriteComplexTest(int argc, char * argv[]) { if (argc != 4) { + std::cerr << "Missing parameters." << std::endl; std::cerr << "Usage: " << itkNameOfTestExecutableMacro(argv) << " inputReal inputImaginary outputComplex" << std::endl; return EXIT_FAILURE; From 7f920d6e5879891bab8a8b63def55b8ace9b99ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20Haitz=20Legarreta=20Gorro=C3=B1o?= Date: Sun, 2 Feb 2025 13:10:03 -0500 Subject: [PATCH 4/6] STYLE: Perform first the test input argument check Perform first the test input argument check across the `ImageCompose` module test files. Take advantage of the commit to add the missing argument message where missing and use the same message consistently. --- .../test/itkImageToVectorImageFilterTest.cxx | 14 +++++++------- .../itkJoinSeriesImageFilterStreamingTest.cxx | 15 +++++++-------- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx index 536896a8474..802d88ebaeb 100644 --- a/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkImageToVectorImageFilterTest.cxx @@ -25,6 +25,13 @@ int itkImageToVectorImageFilterTest(int argc, char * argv[]) { + if (argc < 3) + { + std::cerr << "Missing parameters." << std::endl; + std::cerr << "Usage: " << std::endl; + std::cerr << itkNameOfTestExecutableMacro(argv) << " input1 input2 ... inputn output" << std::endl; + return EXIT_FAILURE; + } using PixelType = unsigned char; @@ -36,13 +43,6 @@ itkImageToVectorImageFilterTest(int argc, char * argv[]) using FilterType = itk::ComposeImageFilter; - if (argc < 3) - { - std::cerr << "Usage: " << std::endl; - std::cerr << itkNameOfTestExecutableMacro(argv) << " input1 input2 ... inputn output" << std::endl; - return EXIT_FAILURE; - } - auto filter = FilterType::New(); int f = 0; for (int i = 1; i < argc - 1; ++i) diff --git a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx index e5cc092483e..aa9c3107d4c 100644 --- a/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkJoinSeriesImageFilterStreamingTest.cxx @@ -27,6 +27,13 @@ int itkJoinSeriesImageFilterStreamingTest(int argc, char * argv[]) { + if (argc < 3) + { + std::cerr << "Missing parameters." << std::endl; + std::cerr << "Usage: " << itkNameOfTestExecutableMacro(argv) << " InputImage OutputImage" << std::endl; + return EXIT_FAILURE; + } + using ImageType = itk::Image; using SliceImageType = itk::Image; @@ -35,14 +42,6 @@ itkJoinSeriesImageFilterStreamingTest(int argc, char * argv[]) using JoinSeriesFilterType = itk::JoinSeriesImageFilter; using ImageFileWriterType = itk::ImageFileWriter; - - if (argc < 3) - { - std::cerr << "Usage: " << itkNameOfTestExecutableMacro(argv) << " InputImage OutputImage" << std::endl; - return EXIT_FAILURE; - } - - const std::string inputFileName = argv[1]; const std::string outputFileName = argv[2]; From 15d75f75ac7d22648c7595ec83f4bcc1d57ac631 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20Haitz=20Legarreta=20Gorro=C3=B1o?= Date: Sun, 2 Feb 2025 13:11:32 -0500 Subject: [PATCH 5/6] STYLE: Remove unnecessary/uninformative comment block in test Remove unnecessary/uninformative comment block in `ImageCompose` module test. --- .../ImageCompose/test/itkComposeRGBAImageFilterTest.cxx | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx b/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx index f0789ff44b6..8711133b3e8 100644 --- a/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkComposeRGBAImageFilterTest.cxx @@ -37,14 +37,6 @@ itkComposeRGBAImageFilterTest(int argc, char * argv[]) << std::endl; } - // ARGUMENTS: - // argv[0] = Executable name - // argv[1] = Output file name and path - // argv[2] = Input 1 file name and path - // argv[2] = Input 2 file name and path - // argv[2] = Input 3 file name and path - // argv[2] = Input 4 file name and path - // Get arguments char * OutputFilename = argv[1]; char * Input1Filename = argv[2]; From 5042dc91b277546d7c1e67f04a6e62797afb3561 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20Haitz=20Legarreta=20Gorro=C3=B1o?= Date: Sun, 2 Feb 2025 13:13:56 -0500 Subject: [PATCH 6/6] STYLE: Do not capitalize variable first letter Do not capitalize variable first letter: adhere to ITK style guidelines. --- .../itkImageReadRealAndImaginaryWriteComplexTest.cxx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx b/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx index 2b2ada8f894..c4eade18bca 100644 --- a/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx +++ b/Modules/Filtering/ImageCompose/test/itkImageReadRealAndImaginaryWriteComplexTest.cxx @@ -61,7 +61,7 @@ itkImageReadRealAndImaginaryWriteComplexTest(int argc, char * argv[]) auto readerImag = ReaderType::New(); auto writer = WriterType::New(); - auto RealAndImaginary2Complex = RealAndImaginary2ComplexFilterType::New(); + auto realAndImaginary2Complex = RealAndImaginary2ComplexFilterType::New(); readerReal->SetFileName(argv[1]); readerImag->SetFileName(argv[2]); @@ -71,12 +71,12 @@ itkImageReadRealAndImaginaryWriteComplexTest(int argc, char * argv[]) readerReal->Update(); readerImag->Update(); - RealAndImaginary2Complex->SetInput1(readerReal->GetOutput()); - RealAndImaginary2Complex->SetInput2(readerImag->GetOutput()); + realAndImaginary2Complex->SetInput1(readerReal->GetOutput()); + realAndImaginary2Complex->SetInput2(readerImag->GetOutput()); - ITK_TRY_EXPECT_NO_EXCEPTION(RealAndImaginary2Complex->Update()); + ITK_TRY_EXPECT_NO_EXCEPTION(realAndImaginary2Complex->Update()); - writer->SetInput(RealAndImaginary2Complex->GetOutput()); + writer->SetInput(realAndImaginary2Complex->GetOutput()); writer->Update(); // check that the default template parameters work