From c63ff5fff98452e494ec58ba5ed628e87da25ab0 Mon Sep 17 00:00:00 2001 From: Matt McCormick Date: Fri, 31 Jan 2020 20:29:19 -0500 Subject: [PATCH 1/2] COMP: Get Input const in CastSpatialObjectFilter To address: In file included from /Users/builder/externalModules/Core/SpatialObjects/test/itkCastSpatialObjectFilterTest.cxx:19: /Users/builder/externalModules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h:74:3: error: use of undeclared identifier 'purposeful_error' itkGetObjectMacro(Input, InputSpatialObjectType); ^ /Users/builder/externalModules/Core/Common/include/itkMacro.h:1040:7: note: expanded from macro 'itkGetObjectMacro' purposeful_error("itkGetObjectMacro should be replaced with itkGetModifiableObjectMacro."); \ ^ 1 error generated. --- .../Core/SpatialObjects/include/itkCastSpatialObjectFilter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h b/Modules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h index 645086b2167..76e388fc81b 100644 --- a/Modules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h +++ b/Modules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h @@ -71,7 +71,7 @@ class ITK_TEMPLATE_EXPORT CastSpatialObjectFilter : public Object using InputChildrenListType = typename InputSpatialObjectType::ChildrenListType; itkSetObjectMacro(Input, InputSpatialObjectType); - itkGetObjectMacro(Input, InputSpatialObjectType); + itkGetConstObjectMacro(Input, InputSpatialObjectType); template std::list * From 26d8016e6dac1e0392f5537f142266a3eb45b87a Mon Sep 17 00:00:00 2001 From: Matt McCormick Date: Fri, 31 Jan 2020 20:33:11 -0500 Subject: [PATCH 2/2] BUG: Address CastSpatialObjectFilter argument to itkTypeMacro Detected by PythonGetNameOfClass test. --- .../Core/SpatialObjects/include/itkCastSpatialObjectFilter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h b/Modules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h index 76e388fc81b..9eb023cee99 100644 --- a/Modules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h +++ b/Modules/Core/SpatialObjects/include/itkCastSpatialObjectFilter.h @@ -64,7 +64,7 @@ class ITK_TEMPLATE_EXPORT CastSpatialObjectFilter : public Object itkNewMacro(Self); - itkTypeMacro(SpatialObjectCastFilter, Object); + itkTypeMacro(CastSpatialObjectFilter, Object); using InputSpatialObjectType = SpatialObject;