Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the itkMemoryProbesCollecterBaseTest useful? It fails on macOS, at least in some conditions #4818

Open
seanm opened this issue Aug 22, 2024 · 2 comments
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Comments

@seanm
Copy link
Contributor

seanm commented Aug 22, 2024

The itkMemoryProbesCollecterBaseTest fails on macOS, at least in some conditions, ex:

https://open.cdash.org/tests/1690707341

where it gives:

Freeing memory should result in less memory but it is 262216kB instead of 262164kB

I have a suspicion that this test is quite old, and being tripped up by modern OS memory management (ex: memory compression and other magic).

I wonder if this test really gives any value?

@seanm seanm added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Aug 22, 2024
@seanm
Copy link
Contributor Author

seanm commented Aug 29, 2024

In fact, unless I've missed something in my searching, itkMemoryProbe* is only used in Examples and Tests...

@dzenanz
Copy link
Member

dzenanz commented Aug 29, 2024

Of course, that class is meant for testing and debugging. Perhaps increase the amount of memory being released? That should prevent it from being lost in the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Development

No branches or pull requests

2 participants