Skip to content

Commit 18d1dc6

Browse files
committed
fix: reduce nest children
Signed-off-by: Innei <[email protected]>
1 parent 655e2ff commit 18d1dc6

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

src/components/ui/viewport/OnlyDesktop.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ export const OnlyDesktop: Component = ({ children }) => {
1616

1717
if (!isLg) return null
1818

19-
return <>{children}</>
19+
return children
2020
}

src/components/ui/viewport/OnlyMobile.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ export const OnlyMobile: Component = ({ children }) => {
1818

1919
if (!isMobile) return null
2020

21-
return <>{children}</>
21+
return children
2222
}

src/providers/root/index.tsx

+8-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { JotaiStoreProvider } from './jotai-provider'
1111
import { ModalStackProvider } from './modal-stack-provider'
1212
import { PageScrollInfoProvider } from './page-scroll-info-provider'
1313
import { SentryProvider } from './sentry-provider'
14-
import { SocketProvider } from './socket-provider'
14+
import { SocketContainer } from './socket-provider'
1515
import { ViewportProvider } from './viewport-provider'
1616

1717
const contexts: JSX.Element[] = [
@@ -21,11 +21,16 @@ const contexts: JSX.Element[] = [
2121
<JotaiStoreProvider key="jotaiStoreProvider" />,
2222
<AggregationProvider key="aggregationProvider" />,
2323
<ViewportProvider key="viewportProvider" />,
24-
<SocketProvider key="socketProvider" />,
24+
2525
<PageScrollInfoProvider key="PageScrollInfoProvider" />,
2626
<DebugProvider key="debugProvider" />,
2727
<ModalStackProvider key="modalStackProvider" />,
2828
]
2929
export function Providers({ children }: PropsWithChildren) {
30-
return <ProviderComposer contexts={contexts}>{children}</ProviderComposer>
30+
return (
31+
<>
32+
<SocketContainer />
33+
<ProviderComposer contexts={contexts}>{children}</ProviderComposer>
34+
</>
35+
)
3136
}

src/providers/root/sentry-provider.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ export const SentryProvider = ({ children }: PropsWithChildren) => {
2020
window.onerror = null
2121
}
2222
}, [])
23-
return <>{children}</>
23+
return children
2424
}

src/providers/root/socket-provider.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
import { useEffect } from 'react'
44

55
// const Context = createContext<TSocketClient>(null as any)
6-
export const SocketProvider: Component = ({ children }) => {
6+
export const SocketContainer: Component = () => {
77
useEffect(() => {
88
import('~/socket').then((module) => {
99
const { socketClient } = module
1010
socketClient.initIO()
1111
})
1212
}, [])
1313

14-
return <>{children}</>
14+
return null
1515
}

0 commit comments

Comments
 (0)