feat: support configuring init container image #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InftyAI-Agent
added
needs-triage
rudeigerc
force-pushed
the
feat/init-container-image
branch
3 times, most recently
from
70861f4 to
621c32d
Compare
Member
|
/kind feature Will continue the review work later. |
InftyAI-Agent
added
feature
kerthcet
reviewed
Jun 13, 2025
Member
|
we need to solve the conflicts first. |
Member
Author
|
@kerthcet Got it. I'll fix the conflicts first and then complement the related unit tests. |
rudeigerc
force-pushed
the
feat/init-container-image
branch
3 times, most recently
from
8ea73a9 to
37925eb
Compare
googs1025
reviewed
Jun 18, 2025
Member
|
@rudeigerc any updated? |
Member
Author
|
@googs1025 Thanks for the reminder. I am out of bandwidth recently, but I will try to make an update this weekend. |
rudeigerc
force-pushed
the
feat/init-container-image
branch
from
37925eb to
0552846
Compare
Member
Author
|
I've updated the test cases by migrating them to /cc @kerthcet @googs1025 |
rudeigerc
force-pushed
the
feat/init-container-image
branch
from
0552846 to
ac82e18
Compare
Signed-off-by: rudeigerc <[email protected]>
rudeigerc
force-pushed
the
feat/init-container-image
branch
from
ac82e18 to
06214ad
Compare
googs1025
reviewed
Jun 30, 2025
Member
|
/lgtm |
InftyAI-Agent
added
the
lgtm
Member
|
/approve Thanks @rudeigerc |
InftyAI-Agent
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This pull request supports configuring the init container image via
init-container-imageinconfig.data.Which issue(s) this PR fixes
Closes #350
Special notes for your reviewer
Please note that only integration tests have been implemented. I think unit tests could be appended after #434 is merged.
Does this PR introduce a user-facing change?