Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to "Forge Mod" while "Include OptiFine" is enabled produces "Error: null" #117

Closed
LeafHacker opened this issue Jan 2, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@LeafHacker
Copy link
Contributor

Describe the bug
If you have OptiFine enabled and switch to the Forge Mod installation mode, you get Error: null along with the following stderr:

{InstallationModeSetting=Forge Mod, MinecraftDirectorySetting=/home/leaf/.minecraft, OptiFineToggleSetting=false, MinecraftVersionSetting=1.12.2, ImpactVersionSetting=io.github.ImpactDevelopment.installer.impact.ImpactVersionReleased@490a00d}
{InstallationModeSetting=Official Launcher, MinecraftDirectorySetting=/home/leaf/.minecraft, OptiFineToggleSetting=false, MinecraftVersionSetting=1.12.2, ImpactVersionSetting=io.github.ImpactDevelopment.installer.impact.ImpactVersionReleased@490a00d}
{InstallationModeSetting=Official Launcher, MinecraftDirectorySetting=/home/leaf/.minecraft, OptiFineToggleSetting=true, MinecraftVersionSetting=1.12.2, ImpactVersionSetting=io.github.ImpactDevelopment.installer.impact.ImpactVersionReleased@490a00d}
OptiFineSetting was invalidated by changing InstallationModeSetting to Forge Mod
{InstallationModeSetting=Forge Mod, MinecraftDirectorySetting=/home/leaf/.minecraft, OptiFineToggleSetting=true, MinecraftVersionSetting=1.12.2, ImpactVersionSetting=io.github.ImpactDevelopment.installer.impact.ImpactVersionReleased@490a00d, OptiFineSetting=null}
java.lang.NullPointerException
	at io.github.ImpactDevelopment.installer.gui.pages.MainPage.shouldInstallButtonBeEnabled(MainPage.java:142)
	at io.github.ImpactDevelopment.installer.gui.pages.MainPage.<init>(MainPage.java:78)
	at io.github.ImpactDevelopment.installer.gui.AppWindow.lambda$recreate$0(AppWindow.java:64)
	at java.awt.event.InvocationEvent.dispatch$$$capture(InvocationEvent.java:311)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:74)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

To Reproduce
Steps to reproduce the behavior:

  1. Go to installation mode "Official Launcher"
  2. Click on Include Optifine: Yes
  3. Switch to installation mode "Forge Mod"
  4. See error

Expected behavior
Expected Forge Mod to either ignore OptiFine enabled state or reset it to something sane (like off)

@LeafHacker LeafHacker added the bug Something isn't working label Jan 2, 2021
@LeafHacker LeafHacker self-assigned this Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant