Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer 0.9.2 & 0.9.3 have default_args.properties in the release build #116

Closed
LeafHacker opened this issue Jan 2, 2021 · 0 comments
Closed

Installer 0.9.2 & 0.9.3 have default_args.properties in the release build #116

LeafHacker opened this issue Jan 2, 2021 · 0 comments
Assignees
@LeafHacker
Labels
bug Something isn't working

Comments

@LeafHacker
Copy link
Contributor

Describe the bug
The release builds for 0.9.2 & 0.9.3 include the default_args.properties file I was using to test dynamically creating the “nightly installer” serverside. This means these releases always show nightly builds!

To Reproduce
Steps to reproduce the behavior:

  1. Go to releases
  2. Download the JAR or EXE for 0.9.2 or 0.9.3
  3. Open them in an Archive Explorer
  4. Notice default_args.properties is present

Expected behavior
default_args.properties should only be present when injected by impact server for “nightly installer” downloads.

Screenshots
image

Additional context
Leaf is dumb dumb
@LeafHacker LeafHacker added the bug Something isn't working label Jan 2, 2021
@LeafHacker LeafHacker self-assigned this Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeafHacker LeafHacker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LeafHacker