Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Install” button hidden when using custom optifine #111

Open
Serial-Comma opened this issue Nov 8, 2020 · 3 comments
Open

“Install” button hidden when using custom optifine #111

Serial-Comma opened this issue Nov 8, 2020 · 3 comments

Comments

@Serial-Comma
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Launch the installer'
  2. Click on 'Include Optifine? (Yes)'
  3. Click under "Optifine version" 'Custom'
  4. After selecting custom optifine version, install button is not clickable or visible anymore

Expected behavior
A clear and concise description of what you expected to happen.
I expected to be able to click on the install button
Screenshots
If applicable, add screenshots to help explain your problem.
image
Desktop (please complete the following information):
Ubuntucinnamon, latest version of impact as of typing.
Smartphone (please complete the following information):
N/A
Additional context
N/A

@MattSturgeon
Copy link

This is caused by GUI scaling/widget size being different on your platform/system theme. That combined with our fixed height window size.

IIRC @leijurv is keen on keeping the window a fixed size without allowing adjustment, however it may be possible to allow the window to either grow or scroll when widgets overflow...

@LeafHacker
Copy link
Contributor

This is caused by [your] GUI scaling/widget size being different [...] combined with our fixed window height.

Yep

IIRC @leijurv is keen on keeping the window a fixed size

Thoughts @leijurv?

@leijurv
Copy link
Member

leijurv commented Dec 19, 2020

I honestly don't remember why, that was a good 18 months ago haha.

We could definitely try making the window resizable, give that a shot. Sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants