Skip to content

Commit 3afd9f3

Browse files
committed
Get zlib, libxml2 and iconv all from Conan.
1 parent 5b47547 commit 3afd9f3

File tree

4 files changed

+25
-20
lines changed

4 files changed

+25
-20
lines changed

.travis.yml

+8-4
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,21 @@ matrix:
99
- APP_NAME="FBX2glTF-linux-x64"
1010
- CONAN_CONFIG="-s compiler.libcxx=libstdc++11"
1111
- FBXSDK_TARBALL="https://github.com/zellski/FBXSDK-Linux/archive/2019.2.tar.gz"
12+
- TAR_WILDCARDS="--wildcards"
1213
- os: osx
1314
osx_image: xcode10.2
1415
env:
1516
- APP_NAME="FBX2glTF-darwin-x64"
1617
- CONAN_CONFIG="-s compiler=apple-clang -s compiler.version=10.0 -s compiler.libcxx=libc++"
1718
- FBXSDK_TARBALL="https://github.com/zellski/FBXSDK-Darwin/archive/2019.2.tar.gz"
19+
- TAR_WILDCARDS=""
1820
compiler: gcc
1921
language: generic
20-
cache:
21-
directories:
22-
- ${HOME}/.conan
22+
23+
#disabled for now
24+
#cache:
25+
# directories:
26+
# - ${HOME}/.conan
2327

2428
addons:
2529
apt:
@@ -28,7 +32,7 @@ addons:
2832
packages: zstd
2933

3034
install:
31-
- curl -sL "${FBXSDK_TARBALL}" | tar xz --strip-components=1 --wildcards */sdk
35+
- curl -sL "${FBXSDK_TARBALL}" | tar xz --strip-components=1 ${TAR_WILDCARDS} */sdk
3236
- zstd -d -r --rm sdk
3337
- git clone --depth 1 git://github.com/astropy/ci-helpers.git
3438
- source ci-helpers/travis/setup_conda.sh

CMakeLists.txt

+13-14
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,16 @@ include("${CMAKE_BINARY_DIR}/conan_paths.cmake")
4141

4242
set(CMAKE_THREAD_PREFER_PTHREAD TRUE)
4343
find_package(Threads REQUIRED)
44-
find_package(Iconv QUIET)
44+
45+
list(INSERT CMAKE_MODULE_PATH 0 "${CMAKE_BINARY_DIR}")
4546

4647
# stuff we get from Conan
47-
find_package(boost_filesystem REQUIRED)
48-
find_package(boost_optional REQUIRED)
49-
find_package(libxml2 REQUIRED)
50-
find_package(zlib REQUIRED)
51-
find_package(fmt REQUIRED)
48+
find_package(boost_filesystem MODULE REQUIRED)
49+
find_package(boost_optional MODULE REQUIRED)
50+
find_package(libxml2 MODULE REQUIRED)
51+
find_package(zlib MODULE REQUIRED)
52+
find_package(fmt MODULE REQUIRED)
53+
find_package(libiconv MODULE REQUIRED)
5254

5355
# create a compilation database for e.g. clang-tidy
5456
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
@@ -202,12 +204,13 @@ target_link_libraries(libFBX2glTF
202204
${FRAMEWORKS}
203205
boost_filesystem::boost_filesystem
204206
boost_optional::boost_optional
205-
fmt::fmt
206-
libxml2::libxml2
207-
zlib::zlib
208207
${DRACO_LIB}
209208
optimized ${FBXSDK_LIBRARY}
210209
debug ${FBXSDK_LIBRARY_DEBUG}
210+
fmt::fmt
211+
libxml2::libxml2
212+
zlib::zlib
213+
libiconv::libiconv
211214
${CMAKE_DL_LIBS}
212215
${CMAKE_THREAD_LIBS_INIT}
213216
)
@@ -219,6 +222,7 @@ target_include_directories(libFBX2glTF PUBLIC
219222
fmt::fmt
220223
libxml2::libxml2
221224
zlib::zlib
225+
libiconv::libiconv
222226
)
223227

224228
target_include_directories(libFBX2glTF SYSTEM PUBLIC
@@ -231,11 +235,6 @@ target_include_directories(libFBX2glTF SYSTEM PUBLIC
231235
${CPPCODEC_INCLUDE_DIR}
232236
)
233237

234-
if (Iconv_FOUND)
235-
target_link_libraries(libFBX2glTF Iconv::Iconv)
236-
target_include_directories(libFBX2glTF SYSTEM PUBLIC Iconv::Iconv)
237-
endif()
238-
239238
target_include_directories(appFBX2glTF PUBLIC
240239
"third_party/CLI11"
241240
)

appveyor.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ environment:
99

1010
stack: python %PYTHON%
1111

12-
cache:
13-
- C:\Users\appveyor\.conan\data -> appveyor.yml, conanfile.py
12+
#temporarily disabled
13+
#cache:
14+
# - C:\Users\appveyor\.conan\data -> appveyor.yml, conanfile.py
1415

1516
init:
1617
- git config --global filter.lfs.required false

conanfile.py

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ class FBX2glTFConan(ConanFile):
1010
settings = "os", "compiler", "build_type", "arch"
1111
requires = (
1212
("boost_filesystem/1.69.0@bincrafters/stable"),
13+
("libiconv/1.15@bincrafters/stable"),
1314
("zlib/1.2.11@conan/stable"),
1415
("libxml2/2.9.9@bincrafters/stable"),
1516
("fmt/5.3.0@bincrafters/stable"),

0 commit comments

Comments
 (0)