Skip to content

Commit 4d2e9bb

Browse files
authored
Merge pull request nyaruka#51 from nyaruka/analytics
Use analytics package from gocommon instead of librato directly
2 parents 2992041 + f337d32 commit 4d2e9bb

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

daemon.go

+6-5
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"sync"
66
"time"
77

8-
"github.com/nyaruka/librato"
8+
"github.com/nyaruka/gocommon/analytics"
99
"github.com/nyaruka/rp-indexer/indexers"
1010
"github.com/sirupsen/logrus"
1111
)
@@ -38,10 +38,11 @@ func NewDaemon(cfg *Config, db *sql.DB, ixs []indexers.Indexer, poll time.Durati
3838
func (d *Daemon) Start() {
3939
// if we have a librato token, configure it
4040
if d.cfg.LibratoToken != "" {
41-
librato.Configure(d.cfg.LibratoUsername, d.cfg.LibratoToken, d.cfg.InstanceName, time.Second, d.wg)
42-
librato.Start()
41+
analytics.RegisterBackend(analytics.NewLibrato(d.cfg.LibratoUsername, d.cfg.LibratoToken, d.cfg.InstanceName, time.Second, d.wg))
4342
}
4443

44+
analytics.Start()
45+
4546
for _, i := range d.indexers {
4647
d.startIndexer(i)
4748
}
@@ -119,7 +120,7 @@ func (d *Daemon) reportStats() {
119120
log := logrus.NewEntry(logrus.StandardLogger())
120121

121122
for k, v := range metrics {
122-
librato.Gauge("indexer."+k, v)
123+
analytics.Gauge("indexer."+k, v)
123124
log = log.WithField(k, v)
124125
}
125126

@@ -129,7 +130,7 @@ func (d *Daemon) reportStats() {
129130
// Stop stops this daemon
130131
func (d *Daemon) Stop() {
131132
logrus.Info("daemon stopping")
132-
librato.Stop()
133+
analytics.Stop()
133134

134135
close(d.quit)
135136
d.wg.Wait()

go.mod

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ require (
66
github.com/evalphobia/logrus_sentry v0.8.2
77
github.com/lib/pq v1.10.5
88
github.com/nyaruka/ezconf v0.2.1
9-
github.com/nyaruka/gocommon v1.20.0
10-
github.com/nyaruka/librato v1.0.0
9+
github.com/nyaruka/gocommon v1.21.0
1110
github.com/olivere/elastic/v7 v7.0.32
1211
github.com/pkg/errors v0.9.1
1312
github.com/sirupsen/logrus v1.8.1
@@ -26,6 +25,7 @@ require (
2625
github.com/mailru/easyjson v0.7.7 // indirect
2726
github.com/naoina/go-stringutil v0.1.0 // indirect
2827
github.com/naoina/toml v0.1.1 // indirect
28+
github.com/nyaruka/librato v1.0.0 // indirect
2929
github.com/pmezard/go-difflib v1.0.0 // indirect
3030
github.com/shopspring/decimal v1.3.1 // indirect
3131
golang.org/x/net v0.0.0-20220425223048-2871e0cb64e4 // indirect

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ github.com/naoina/toml v0.1.1 h1:PT/lllxVVN0gzzSqSlHEmP8MJB4MY2U7STGxiouV4X8=
3232
github.com/naoina/toml v0.1.1/go.mod h1:NBIhNtsFMo3G2szEBne+bO4gS192HuIYRqfvOWb4i1E=
3333
github.com/nyaruka/ezconf v0.2.1 h1:TDXWoqjqYya1uhou1mAJZg7rgFYL98EB0Tb3+BWtUh0=
3434
github.com/nyaruka/ezconf v0.2.1/go.mod h1:ey182kYkw2MIi4XiWe1FR/mzI33WCmTWuceDYYxgnQw=
35-
github.com/nyaruka/gocommon v1.20.0 h1:qbxRsBBPvpfGbuBq08jlQGxa5t+UZX/YGV7+kR+/moM=
36-
github.com/nyaruka/gocommon v1.20.0/go.mod h1:JrQSLAPo9ezSy1AzsJ1zDr1HW0/eu+aipICJkN/+kpg=
35+
github.com/nyaruka/gocommon v1.21.0 h1:nu7M2cdSPrkqUPdGsEeWX047+neo69H4x+4g/OKpoLM=
36+
github.com/nyaruka/gocommon v1.21.0/go.mod h1:cv9r6amof1gSktfPZROClZhLFzdSIH/N9KbW6Nny4g8=
3737
github.com/nyaruka/librato v1.0.0 h1:Vznj9WCeC1yZXbBYyYp40KnbmXLbEkjKmHesV/v2SR0=
3838
github.com/nyaruka/librato v1.0.0/go.mod h1:pkRNLFhFurOz0QqBz6/DuTFhHHxAubWxs4Jx+J7yUgg=
3939
github.com/olivere/elastic/v7 v7.0.32 h1:R7CXvbu8Eq+WlsLgxmKVKPox0oOwAE/2T9Si5BnvK6E=

0 commit comments

Comments
 (0)