Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added basicProfileDetails page and upload icon #888

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Added basicProfileDetails page and upload icon #888

merged 3 commits into from
Sep 10, 2020

Conversation

Dishebh
Copy link
Member

@Dishebh Dishebh commented Jul 1, 2020 •
edited
Loading

divyanshu-rawat
divyanshu-rawat reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@divyanshu-rawat divyanshu-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Paarmita can you please check the UI.

@Dishebh
Copy link
Member Author

Dishebh commented Jul 9, 2020

@Paarmita same here :)

Paarmita
Paarmita requested changes Jul 11, 2020
View reviewed changes
Copy link
Member

@Paarmita Paarmita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dishebh Same input size issue here, can you please fix that first.

@Dishebh
Copy link
Member Author

Dishebh commented Jul 11, 2020

PR #899 fixes the input size issue as well, now.

@divyanshu-rawat
Copy link
Member

please compare with original UI, here is the link to the frame https://www.figma.com/file/BrP5RowC7va50HyETZQUDA/Ignitus-Design?node-id=3273%3A15

divyanshu-rawat
divyanshu-rawat reviewed Jul 19, 2020
View reviewed changes
Copy link
Member

@divyanshu-rawat divyanshu-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to resolve UI changes then I will have a look into the code!

@Dishebh
Copy link
Member Author

Dishebh commented Jul 20, 2020 •
edited
Loading

@divyanshu-rawat I'll update the UI of this after the PR #899 gets merged, as I have changed the Input component there.

divyanshu-rawat
divyanshu-rawat reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@divyanshu-rawat divyanshu-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review it tom. :) @Dishebh

@divyanshu-rawat
Copy link
Member

#899 is already merged! :)

@Dishebh Dishebh linked an issue Aug 13, 2020 that may be closed by this pull request
User signUp flow 🎯 #877
Closed
divyanshu-rawat
divyanshu-rawat approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@divyanshu-rawat divyanshu-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divyanshu-rawat divyanshu-rawat changed the title added basicProfileDetails page and upload icon Added basicProfileDetails page and upload icon Sep 10, 2020
@divyanshu-rawat divyanshu-rawat merged commit fbd5eec into Ignitus:develop Sep 10, 2020
@divyanshu-rawat divyanshu-rawat mentioned this pull request Sep 10, 2020
Closed
@Dishebh Dishebh deleted the basic branch September 11, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paarmita Paarmita Paarmita requested changes

@divyanshu-rawat divyanshu-rawat divyanshu-rawat approved these changes

@Marvin9 Marvin9 Awaiting requested review from Marvin9

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User signUp flow 🎯
3 participants
@Dishebh @divyanshu-rawat @Paarmita