Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#858] feat: Add gitbook as supporter #859

Merged
merged 2 commits into from
Jun 2, 2020
Merged

[#858] feat: Add gitbook as supporter #859

merged 2 commits into from
Jun 2, 2020

Conversation

steric85
Copy link
Contributor

@steric85 steric85 commented Jun 2, 2020 •
edited
Loading

@steric85 steric85 changed the title [858] feat: Add gitbook as supporter [#858] feat: Add gitbook as supporter Jun 2, 2020
@steric85 steric85 mentioned this pull request Jun 2, 2020
Closed
@steric85
Copy link
Contributor Author

steric85 commented Jun 2, 2020

I have a few doubts in this.

  1. We'll need to use a different image as this one shows the logo along with the grey-white grid.
  2. We'll need to add this logo to ignitus_assets.

@divyanshu-rawat
Copy link
Member

divyanshu-rawat commented Jun 2, 2020 •
edited
Loading

I have a few doubts in this.

  1. We'll need to use a different image as this one shows the logo along with the grey-white grid.

Sure, it would be great id you can find a suitable SVG logo.

  1. We'll need to add this logo to ignitus_assets.

You can add it here as of now, later I will post it to the GCP.

@steric85
Copy link
Contributor Author

steric85 commented Jun 2, 2020

Updated the gitbook logo.

divyanshu-rawat
divyanshu-rawat approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@divyanshu-rawat divyanshu-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steric85 LGTM :)

@divyanshu-rawat divyanshu-rawat merged commit fa89dad into Ignitus:develop Jun 2, 2020
@divyanshu-rawat divyanshu-rawat mentioned this pull request Jun 2, 2020
Merged
@divyanshu-rawat divyanshu-rawat linked an issue Jun 7, 2020 that may be closed by this pull request
Add GitBook as supporter 👋 #858
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshu-rawat divyanshu-rawat divyanshu-rawat approved these changes

@Marvin9 Marvin9 Awaiting requested review from Marvin9

@Paarmita Paarmita Awaiting requested review from Paarmita

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GitBook as supporter 👋
2 participants
@steric85 @divyanshu-rawat