Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDown z-index in opportunity filters 🔨 #740

Closed
divyanshu-rawat opened this issue Apr 5, 2020 · 4 comments
Closed

DropDown z-index in opportunity filters 🔨 #740

divyanshu-rawat opened this issue Apr 5, 2020 · 4 comments
Labels
enhancement New feature or improvement of existing feature. gssoc20 Girls script summer of code 2020. help wanted Extra attention is needed. medium Something that is somewhat complex to work on. no-issue-activity RGSoC 2020 Rails girls summer of code 2020

Comments

@divyanshu-rawat
Copy link
Member

Describe the bug
I just refactored #723 , durning refactoring I removed presence of css property position, which we avoid to use, so removing it causes z-index to not work properly.

To Reproduce
You can check the behaviour here.
https://deploy-preview-710--peaceful-nightingale-55a1b7.netlify.com/interface/opportunityPosted

Expected behaviour
Expected behaviour is to not increase the height of flex container, instead using z-index over the container encapsulating the entire opportunity content.

Screenshots
filters

Additional context
It would be great if we can achieve this without replying on position property of css, some references that show how we can use z-index with flex without setting position property.

https://stackoverflow.com/questions/45398088/z-index-doesnt-work-with-flex-elements
https://www.freecodecamp.org/forum/t/z-index-isnt-working-in-flexbox/183591

@divyanshu-rawat divyanshu-rawat added enhancement New feature or improvement of existing feature. medium Something that is somewhat complex to work on. gssoc20 Girls script summer of code 2020. help wanted Extra attention is needed. RGSoC 2020 Rails girls summer of code 2020 labels Apr 5, 2020
@nooras
Copy link

nooras commented Apr 9, 2020

Hello @divyanshu-rawat Can I work on this ??

@Dishebh
Copy link
Member

Dishebh commented May 19, 2020

@divyanshu-rawat I would like to work on the issue.

@Dishebh
Copy link
Member

Dishebh commented May 20, 2020

@divyanshu-rawat shouldn't adding a height to the container solve the issue? I tried the links you mentioned above, but did not get any fruitful results. Maybe we should try fixing the height using max-height on hover state, or maybe even assigning a height to the whole container so it won't overflow?

@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement of existing feature. gssoc20 Girls script summer of code 2020. help wanted Extra attention is needed. medium Something that is somewhat complex to work on. no-issue-activity RGSoC 2020 Rails girls summer of code 2020
Projects
None yet
Development

No branches or pull requests

3 participants