Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring (WIP) 🚀🔨 #613

Merged
merged 4 commits into from
Mar 12, 2020
Merged

Code refactoring (WIP) 🚀🔨 #613

merged 4 commits into from
Mar 12, 2020

Conversation

divyanshu-rawat
Copy link
Member

Code refactoring 🚀🔨

@auto-assign auto-assign bot requested review from debck, gittysachin and Paarmita March 11, 2020 21:32
@codecov
Copy link

codecov bot commented Mar 11, 2020 •
edited
Loading

Codecov Report

Merging #613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              master        #613   +/-   ##
=============================================
  Coverage   18.55501%   18.55501%           
=============================================
  Files             75          75           
  Lines            609         609           
  Branches         129         129           
=============================================
  Hits             113         113           
  Misses           496         496
Impacted Files Coverage Δ
after/src/ignitus-GetStarted/sagas.js
after/src/ignitus-Introduction/actionTypes.js
...r/src/ignitus-Introduction/Components/Constants.js
.../ignitus-Student-Dashboard/Components/Dashboard.js
...tus-Dashboard-Header/Components/dashBoardHeader.js
after/src/ignitus-Testimonial/constants.js
after/src/ignitus-Student-Dashboard/sagas.js
after/src/ignitus-GetStarted/actionTypes.js
after/src/ignitus-Testimonial/reducers.js
after/src/ignitus-Dashboard-Header/constants.js
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9bca8d...f64e925. Read the comment docs.

@divyanshu-rawat divyanshu-rawat temporarily deployed to ignitus-pipe-develop-anntr3okh March 11, 2020 21:34 Inactive
@divyanshu-rawat divyanshu-rawat temporarily deployed to ignitus-pipe-develop-anntr3okh March 11, 2020 21:34 Inactive
@divyanshu-rawat divyanshu-rawat temporarily deployed to ignitus-pipe-develop-anntr3okh March 11, 2020 21:39 Inactive
@divyanshu-rawat divyanshu-rawat mentioned this pull request Mar 11, 2020
Closed
@divyanshu-rawat divyanshu-rawat changed the title Code refactoring 🚀🔨 Code refactoring (WIP) 🚀🔨 Mar 11, 2020
@divyanshu-rawat divyanshu-rawat mentioned this pull request Mar 11, 2020
Closed
@divyanshu-rawat divyanshu-rawat linked an issue Mar 11, 2020 that may be closed by this pull request
Code readability 🧹 #612
Closed
gittysachin
gittysachin reviewed Mar 12, 2020
View reviewed changes
Copy link
Member

@gittysachin gittysachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@divyanshu-rawat divyanshu-rawat temporarily deployed to ignitus-pipe-develop-anntr3okh March 12, 2020 15:03 Inactive
hound[bot]
hound bot reviewed Mar 12, 2020
View reviewed changes
src/ignitus-Routes/publicRoutes.js
@@ -33,7 +33,7 @@ const Loading = () => (
);

const AboutUs = Loadable({
loader: () => import("../ignitus-About/Components/About"),
loader: () => import("../ignitus-AboutPage/ignitus-About/Components/About"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token import

src/ignitus-AboutPage/ignitus-Team/sagas.ts
@@ -1,6 +1,6 @@
import { effects } from 'redux-saga';
import * as t from './actionTypes';
import * as api from '../ignitus-Api';;
import * as api from '../../ignitus-Api';;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected 1 empty line after import statement not followed by another import import/newline-after-import
Missing whitespace after semicolon semi-spacing
Unnecessary semicolon no-extra-semi

@divyanshu-rawat divyanshu-rawat temporarily deployed to ignitus-pipe-develop-anntr3okh March 12, 2020 15:05 Inactive
@divyanshu-rawat divyanshu-rawat self-assigned this Mar 12, 2020
@divyanshu-rawat divyanshu-rawat added the enhancement New feature or improvement of existing feature. label Mar 12, 2020
divyanshu-rawat
divyanshu-rawat commented Mar 12, 2020
View reviewed changes
Copy link
Member Author

@divyanshu-rawat divyanshu-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging 👍

@divyanshu-rawat divyanshu-rawat merged commit dcb5b2c into master Mar 12, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

@debck debck Awaiting requested review from debck

@Paarmita Paarmita Awaiting requested review from Paarmita

@gittysachin gittysachin Awaiting requested review from gittysachin

Assignees

@divyanshu-rawat divyanshu-rawat

Labels
enhancement New feature or improvement of existing feature. PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code readability 🧹
2 participants
@divyanshu-rawat @gittysachin