Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Change EF stores to use SaveChangesAsync #3507

Closed
mackie1001 opened this issue Aug 1, 2019 · 3 comments
Closed

Change EF stores to use SaveChangesAsync #3507

mackie1001 opened this issue Aug 1, 2019 · 3 comments

Comments

@mackie1001
Copy link

mackie1001 commented Aug 1, 2019

Something tells me this has come up in conversation before but a search of the issues didn't reveal anything.

I'd like to politely request that the default shipping EF stores (e.g. https://github.com/IdentityServer/IdentityServer4/blob/2.4.0/src/EntityFramework.Storage/src/Stores/PersistedGrantStore.cs) use SaveChangesAsync instead of the synchronous SaveChanges method and also ToListAsync instead of ToList for queries.

I'm trying to ensure that our heavily trafficked application has as little blocking IO as possible and noticed this on my travels.

@brockallen
Copy link
Member

dup: #2067

@mackie1001
Copy link
Author

Thanks, I knew I'd seen it discussed.

@lock
Copy link

lock bot commented Jan 10, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants