Skip to content
This repository has been archived by the owner on Dec 14, 2017. It is now read-only.

Oracle support #28

Open
designsinnovate opened this issue May 29, 2017 · 0 comments
Open

Oracle support #28

designsinnovate opened this issue May 29, 2017 · 0 comments

Comments

@designsinnovate
Copy link

Hello,

I followed steps from Support for other RDBMS than SQL Server for adding Oracle support.

But ran into issues trying IdentityAdmin and followed the trail to IdentityAdminCoreManager.cs that uses hard coded DB context instances.

At first I thought I could just write my own service like shown here, copy paste the entire IdentityAdminCoreManager code, and then modify all contexts with my own

  • maintenance hell in my opinion if I ever want to use updated manager class

Then I thought I could create a new class constructor that accepts DB contexts but being very new to EF, I wasn't sure of impacts this would cause having single instance of each DB context. I noticed manager class methods creates and disposes a context instance each time it is invoked

So I am trying out this 3rd option where I can set the type of context and use that to create an instance. It's working great.

designsinnovate@3b05a0e

Could you please review the change when you get a chance? I will go ahead and update rest of the class and submit a pull request if this approach seems ok.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant