Skip to content

Support PHP 8.5 #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lippserd merged 3 commits into from
Jan 14, 2026
Merged

Support PHP 8.5 #258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a3adf6
Mark param explicitly as nullable
sukhwinder33445 Dec 2, 2025
84868dd
Replace deprecated (since php8.5) PDO constant `PDO::MYSQL_ATTR_INIT_…
sukhwinder33445 Dec 2, 2025
2168ef0
Cleanup phpstan-baseline-8x
sukhwinder33445 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Mark param explicitly as nullable 
- Deprecated in PHP 8.4
  • Loading branch information
@sukhwinder33445
sukhwinder33445 committed Jan 14, 2026
commit 8a3adf635f1a0455ccba0067119e0f6984e33ae0
2 changes: 1 addition & 1 deletion application/forms/Jobs/JobConfigForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class JobConfigForm extends CompatForm
/** @var ?X509Job */
protected $job;

public function __construct(X509Job $job = null)
public function __construct(?X509Job $job = null)
{
$this->job = $job;

Expand Down
2 changes: 1 addition & 1 deletion application/forms/Jobs/ScheduleForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class ScheduleForm extends CompatForm
/** @var ScheduleElement */
protected $scheduleElement;

public function __construct(X509Schedule $schedule = null)
public function __construct(?X509Schedule $schedule = null)
{
$this->schedule = $schedule;

Expand Down
4 changes: 2 additions & 2 deletions library/X509/Hook/SniHook.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ public static function getAll()
/**
* Aggregate pairs of ip => hostname
*
* @param Filter $filter
* @param ?Filter $filter
*
* @return \Generator
*/
abstract public function getHosts(Filter $filter = null);
abstract public function getHosts(?Filter $filter = null);
}
2 changes: 1 addition & 1 deletion library/X509/Job.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class Job implements Task
* @param array<string, array<string>> $snimap The configured SNI maps to be used by this job
* @param ?Schedule $schedule
*/
public function __construct(string $name, array $cidrs, array $ports, array $snimap, Schedule $schedule = null)
public function __construct(string $name, array $cidrs, array $ports, array $snimap, ?Schedule $schedule = null)
{
$this->name = $name;
$this->db = Database::get();
Expand Down