Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to downloading jokes #24

Closed
helgeolav opened this issue Dec 29, 2023 · 2 comments
Closed

Add context to downloading jokes #24

helgeolav opened this issue Dec 29, 2023 · 2 comments

Comments

@helgeolav
Copy link

I would like to make Fetch context aware. The simplest way to do so is to create a FetchWithContext that accepts a context as the first parameter. This will make sure that we don't break any existing code. Doing so will result in Fetch calling FetchWithContext with context.Background().

Is this acceptable?

@Icelain
Copy link
Owner

Icelain commented Dec 30, 2023

Thanks for the suggestion. It is a good idea to add a fetch method with context. PRs are always welcome nonetheless I'll add it by today most likely.

@Icelain
Copy link
Owner

Icelain commented Dec 30, 2023

Done with #26

@Icelain Icelain closed this as completed Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants