Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure renovate to only use chore(deps) #5952

Closed
monperrus opened this issue Aug 26, 2024 · 3 comments · Fixed by #5953
Closed

configure renovate to only use chore(deps) #5952

monperrus opened this issue Aug 26, 2024 · 3 comments · Fixed by #5953

Comments

@monperrus
Copy link
Collaborator

monperrus commented Aug 26, 2024

renovate creates PR with both chore(deps) and fix(deps) as commit message.

this pollutes our changelogs eg https://github.com/INRIA/spoon/releases/tag/v11.1.1-beta-2

I would argue that dependency updates are not fixes is the sense we mean it, and that all renovate PRs in our changelogs should be under Tasks

task: configure renovate to only use chore(deps)

reference documentation: https://docs.renovatebot.com/semantic-commits/

cc/ @rarkins FYI

@rarkins
Copy link

rarkins commented Aug 27, 2024

In semantic versioning, chore commits don't increment a version while fix ones do. Technically speaking a production dependency update can change functionality and therefore should trigger a new version. I prefer to use build than fix for my own projects, but still to trigger a version.

@monperrus
Copy link
Collaborator Author

I understand that you're referring to "dependency-aware semver", where a major/minor change in a dependency triggers a corresponding version update in the project, as a ripple effect. That's an interesting pov to discuss.

Also, we agree that fix is not the best prefix for commit messages and changelog generation, I like your proposal of having build, it's even better than chore.

@monperrus
Copy link
Collaborator Author

PR at #5953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants