Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy for creating submodules #4919

Closed
monperrus opened this issue Sep 26, 2022 · 3 comments
Closed

policy for creating submodules #4919

monperrus opened this issue Sep 26, 2022 · 3 comments

Comments

@monperrus
Copy link
Collaborator

This issue documents our policy for creating submodules.

By default, we prefer to keep everything in spoon-core, in order to have the easiest possible integration.

We create submodules when

  1. the functionality would bloat the spoon-core binary too much

OR

  1. the functionality is too experimental / too unstable to meet the quality standard of spoon-core
@monperrus
Copy link
Collaborator Author

Comments welcome! We'll update the top comment afterwards.

@slarse
Copy link
Collaborator

slarse commented Sep 27, 2022

Stuff like this should IMO go into CONTRIBUTING.md, as this is all about how to contribute. I don't think anyone would think to look for this kind of information in an issue, and I think issues should be actionable (and subsequently closed).

But we can discuss it here before we put it anywhere more permanent (and discoverable). What I feels is missing is our (the Spoon integrators') commitment to maintaining submodules. It ties into the "experimental" part, but it's not only about stability, it's also about the fact that we might entirely drop the submodule if we end up feeling like we can't maintain it. I felt that was @MartinWitt's motivation for makeng #4748 a submodule in the first place.

@monperrus
Copy link
Collaborator Author

Thanks @slarse superseded by #4930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants