refactor: remove unnecessary DirectPrinterHelper (#3425)

Author: monperrus

src/main/java/spoon/reflect/visitor/PrinterHelper.java

@@ -298,4 +298,8 @@ public void setLineSeparator(String lineSeparator) {
 	public void writeSpace() {
 		this.write(' ');
 	}
+
+	public void setShouldWriteTabs(boolean b) {
+		this.shouldWriteTabs = b;
+	}
 }

src/main/java/spoon/support/sniper/SniperJavaPrettyPrinter.java

@@ -173,7 +173,7 @@ public void printSourceFragment(SourceFragment fragment, ModificationStatus isMo
 						//push the context of this collection
 						pushContext(listContext);
 					}
-					mutableTokenWriter.getPrinterHelper().directPrint(fragment.getSourceCode());
+					mutableTokenWriter.directPrint(fragment.getSourceCode());
 				}
 			}
 		});
@@ -266,7 +266,7 @@ public void printSourceFragment(SourceFragment fragment, ModificationStatus isMo
 					//and scan first element of that collection again in new context of that collection
 					if (ModificationStatus.NOT_MODIFIED.equals(isModified)) {
 						// we print the original source code
-						mutableTokenWriter.getPrinterHelper().directPrint(fragment.getSourceCode());
+						mutableTokenWriter.directPrint(fragment.getSourceCode());
 					} else {
 						// we print with the new list context
 						listContext.print(this);
@@ -275,7 +275,7 @@ public void printSourceFragment(SourceFragment fragment, ModificationStatus isMo
 					ElementSourceFragment sourceFragment = (ElementSourceFragment) fragment;
 					if (isModified == ModificationStatus.NOT_MODIFIED) {
 						//nothing is changed, we can print origin sources of this element
-						mutableTokenWriter.getPrinterHelper().directPrint(fragment.getSourceCode());
+						mutableTokenWriter.directPrint(fragment.getSourceCode());
 						return;
 					}
 
@@ -304,11 +304,6 @@ private void executePrintEventInContext(PrinterEvent event) {
 		if (sfc == null) {
 			throw new SpoonException("Missing SourceFragmentContext");
 		}
-		if (mutableTokenWriter.isMuted()) {
-			// the printer may require to update its state based on this event
-			sfc.update(event);
-			return;
-		}
 		// the context-dependent printer handles the event
 		sfc.print(event);
 	}

src/main/java/spoon/support/sniper/internal/AbstractSourceFragmentPrinter.java

@@ -49,6 +49,10 @@ protected AbstractSourceFragmentPrinter(MutableTokenWriter mutableTokenWriter, C
 
 	@Override
 	public void print(PrinterEvent event) {
+		if (mutableTokenWriter.isMuted()) {
+			return;
+		}
+
 		int prevIndex = childFragmentIdx;
 		int index = update(event);
 		if (index != -1) { // means we have found a source code fragment corresponding to this event
@@ -183,7 +187,7 @@ protected void printOriginSpacesUntilFragmentIndex(int fromIndex, int toIndex) {
 							mutableTokenWriter.writeComment(comment);
 						} else {
 							//comment is not modified write origin sources
-							mutableTokenWriter.getPrinterHelper().directPrint(fragment.getSourceCode());
+							mutableTokenWriter.write(fragment.getSourceCode());
 						}
 						//we printed the comment, so we can print next space too
 						canPrintSpace = true;
@@ -195,7 +199,7 @@ protected void printOriginSpacesUntilFragmentIndex(int fromIndex, int toIndex) {
 				}
 			} else if (isSpaceFragment(fragment) && canPrintSpace) {
 				if (!skipSpaceAfterDeletedElement) {
-					mutableTokenWriter.getPrinterHelper().directPrint(fragment.getSourceCode());
+					mutableTokenWriter.write(fragment.getSourceCode());
 				} else {
 					skipSpaceAfterDeletedElement = false;
 				}

src/main/java/spoon/support/sniper/internal/DirectPrinterHelper.java

@@ -10,6 +10,7 @@
 import spoon.compiler.Environment;
 import spoon.reflect.code.CtComment;
 import spoon.reflect.visitor.DefaultTokenWriter;
+import spoon.reflect.visitor.PrinterHelper;
 import spoon.reflect.visitor.TokenWriter;
 
 /**
@@ -22,7 +23,7 @@ public class MutableTokenWriter implements TokenWriter {
 	private boolean muted = false;
 
 	public MutableTokenWriter(Environment env) {
-		this.delegate = new DefaultTokenWriter(new DirectPrinterHelper(env));
+		this.delegate = new DefaultTokenWriter(new PrinterHelper(env));
 	}
 
 	/**
@@ -129,8 +130,8 @@ public TokenWriter decTab() {
 		return this;
 	}
 	@Override
-	public DirectPrinterHelper getPrinterHelper() {
-		return (DirectPrinterHelper) delegate.getPrinterHelper();
+	public PrinterHelper getPrinterHelper() {
+		return delegate.getPrinterHelper();
 	}
 	@Override
 	public void reset() {
@@ -152,4 +153,29 @@ public TokenWriter writeSpace() {
 	public String toString() {
 		return delegate.toString();
 	}
+
+	/**
+	 * Prints a piece of text regardless of mute status
+	 * Don't call this, this is dangerous and irregular design.
+	 */
+	public void directPrint(String text) {
+		int len = text.length();
+		// we do it char by char because there is no write(String) in PrinterHelper
+		for (int i = 0; i < len; i++) {
+			char c = text.charAt(i);
+			//avoid automatic writing of tabs in the middle of text, because write(char) keeps putting it back to true
+			getPrinterHelper().setShouldWriteTabs(false);
+			getPrinterHelper().write(c);
+		}
+	}
+
+	/** writes the piece of text if not muted */
+	public TokenWriter write(String text) {
+		if (isMuted()) {
+			return this;
+		}
+		directPrint(text);
+		return this;
+	}
+
 }