Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug with findHit (document view) #533

Open
KCMertens opened this issue Oct 14, 2024 · 0 comments
Open

Minor bug with findHit (document view) #533

KCMertens opened this issue Oct 14, 2024 · 0 comments
Labels

Comments

@KCMertens
Copy link
Member

There are two conflicting methods for hit navigation in the article view that can cause the current page in the document to change when the website is reloaded. (when the current url contains only findHit, findHit is removed and replaced by #hit-index e.g. #10. When refreshing, there are no longer wordstart/wordend parameter, and no findHit, the backend will serve the first page (with a hit?).

How it should work:

  • The url as seen by javascript should always be the combination of wordstart/wordend/#hit-index
  • The url in the back-end can be either findhit, or wordstart/wordend/#hit-index. It should be converted to the frontend format and redirect.
  • The frontend paginator should just generate a new wordstart/wordend/#hit-index url.
@KCMertens KCMertens added the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant