From 9091082c6e3a2a3b1e002f831c47068559a96e6b Mon Sep 17 00:00:00 2001
From: KCMertens <koen.mertens@ivdnt.org>
Date: Tue, 23 May 2023 12:52:16 +0300
Subject: [PATCH] Add null check when rendering metadata in hits table

Hopefully fix null error encountered by @eduarddrenth
---
 src/frontend/src/pages/search/results/table/HitResults.vue | 2 +-
 src/frontend/src/types/blacklabtypes.ts                    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/frontend/src/pages/search/results/table/HitResults.vue b/src/frontend/src/pages/search/results/table/HitResults.vue
index 536d27b2a..18f8c33a8 100644
--- a/src/frontend/src/pages/search/results/table/HitResults.vue
+++ b/src/frontend/src/pages/search/results/table/HitResults.vue
@@ -110,7 +110,7 @@
 								<td><span :dir="textDirection">{{rowData.right}}</span>&hellip;</td>
 							</template>
 							<td v-for="(v, index) in rowData.other" :key="index">{{v}}</td>
-							<td v-for="meta in shownMetadataCols" :key="meta.id">{{rowData.doc[meta.id].join(', ')}}</td>
+							<td v-for="meta in shownMetadataCols" :key="meta.id">{{rowData.doc[meta.id] ? rowData.doc[meta.id].join(', ') : ''}}</td>
 						</tr>
 						<tr v-if="citations[index]" v-show="citations[index].open" :key="index + '-citation'" :class="['concordance-details', {'open': citations[index].open}]">
 							<td :colspan="numColumns">
diff --git a/src/frontend/src/types/blacklabtypes.ts b/src/frontend/src/types/blacklabtypes.ts
index acfcc0928..0e6382e1b 100644
--- a/src/frontend/src/types/blacklabtypes.ts
+++ b/src/frontend/src/types/blacklabtypes.ts
@@ -440,7 +440,7 @@ export interface BLTermOccurances {
 	};
 }
 
-/** Contains all metadata for a document */
+/** Contains all metadata for a document. Fields without indexed values are omitted! */
 export type BLDocInfo = {
 	lengthInTokens: number;
 	mayView: boolean;