Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new actions for reasoned diffs and rebuilding imports ("ontobot") #480

Open
cmungall opened this issue Oct 7, 2021 · 1 comment
Open
Assignees
Milestone

Comments

@cmungall
Copy link
Contributor

cmungall commented Oct 7, 2021

@balhoff set up a jenkins job for GO that will rebuild extracted import modules and make a PR.

https://gist.github.com/balhoff/6c0d434b1601de4d4006bff76b858ac1

On slack he mentioned it would be possible to translate this to a github action.

He also set up a github action for doing a reasoned diff as a PR:
https://github.com/geneontology/go-ontology/blob/master/.github/workflows/inference_diff.yml

It would be great to have both actions available in the template

I am not sure if there are other considerations

  • should it be throttled, e.g. certain kinds of changes could generate very large markdown files
  • we only want the import diff to run under some circumstances

See also

Which is about having a github action to make a draft release

@balhoff
Copy link
Member

balhoff commented Oct 7, 2021

I think the two could be separate actions. The diff action can run on an import update PR just as it runs on user edit PRs. No reason to mix the diffing into the import update.

@matentzn matentzn added this to the 1.5 milestone Mar 12, 2023
@anitacaron anitacaron modified the milestones: 1.5, 1.6 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants