Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #118

Closed
cmungall opened this issue Oct 27, 2018 · 5 comments
Closed

Add integration tests #118

cmungall opened this issue Oct 27, 2018 · 5 comments

Comments

@cmungall
Copy link
Contributor

As well as self-contained unit tests, new ontologies should be tested for consistency against some to be defined merged set of base files of core OBOs

@matentzn
Copy link
Contributor

matentzn commented Nov 2, 2018

@cmungall +1
can you give a little bit more detail? I assume the tests should be conducted as part of the pre_release/release cycle, and should be implemented right where these SPARQL tests are happening (no equivalent, unsat classes etc). which ontologies where you thinking to test against?

@cmungall
Copy link
Contributor Author

cmungall commented Nov 2, 2018

There are a few possibilities, not mutually exclusive. We also to have to take into account considerations like tractable travis builds.

Current thinking:

as part of each RO release N we build a merged set of base ontologies, to be in the set you should be using RO in a meaningful way. This ro-users ontology can be released as part of the RO release, but just logical axioms, and zipped. Not intended for general consumption.

Then, for each travis build on each snapshot / candidate release N+1, we download ro-users (or use local copy if it is small enough) and test the combo of ro_users + ro_edit.

Occasionally we will hit deadlock situations, when we need to introduce a breaking change. Here we work with the upstreams and then release a new ro-users, when we can break the deadlock.

@cmungall
Copy link
Contributor Author

cmungall commented Nov 2, 2018

OWL-ZIP might be useful here: owlcs/owlapi#375

@cmungall
Copy link
Contributor Author

cmungall commented Nov 2, 2018

The test I am envisioning above is just coherency.

But would be good to have a proper test framework, where we can state expected outcomes of inference

@matentzn
Copy link
Contributor

matentzn commented Feb 5, 2022

For now, we test against the imports, but we will revive this issue anyways when the time for COB comes.

@matentzn matentzn closed this as completed Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants