Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate lowered coverage of /src/mocks/response/ in coveralls.io #292

Closed
mleu opened this issue May 16, 2017 · 1 comment
Closed

investigate lowered coverage of /src/mocks/response/ in coveralls.io #292

mleu opened this issue May 16, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@mleu
Copy link
Member

mleu commented May 16, 2017

Timeboxed 1h

PR #291 has lead to lowered coverage in all files in /src/mocks/response/ on lines which call super(new ResponseOptions(...)).

Local coverage report does not see these lines as as missed, but also does not see them as hit.

The reason for the lowered coverage is that typescript changed the way they call super constructors
See microsoft/TypeScript#13029

There are a few people telling that changing jasmine compilerOptions to es6 should solve this issue but i don't think this is the way to go.
Izhaki/gefri@30f0591

I think the best is to wait until newer version will handle this issue. Or with adding a skip next line hint for jasmine on the typescript side or the remapper knows what to do.
gotwarlost/istanbul#690

@mleu
Copy link
Member Author

mleu commented Jun 11, 2017

Well researched @sandrozbinden, thanks! I agree, let's live with it until a fix emerges...

@mleu mleu closed this as completed Jun 11, 2017
@ghost ghost removed the needs review label Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants