Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile application: update built-in scripts, not apk. #63

Open
johnd0e opened this issue Jan 16, 2019 · 3 comments
Open

Mobile application: update built-in scripts, not apk. #63

johnd0e opened this issue Jan 16, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed mobile

Comments

@johnd0e
Copy link
Contributor

johnd0e commented Jan 16, 2019

Currently IITC for desktop is updated automatically by GM/TM (well, after #32 resolved).

Mobile is also capable to update plugins, but only external.
So why do not update built-in scripts in the same manner?

In most cases it's enough to update scrips, and leave 'old' apk (well, there could be rare exceptions 0ae25e1).

@modos189
Copy link
Contributor

In the Advanced menu there is a setting for updating. By default, updates are checked every week. I'm not sure if it works, but after #32 will need to check

@johnd0e
Copy link
Contributor Author

johnd0e commented Jan 18, 2019

I'm sure that it works as I use it. But: updates now are checked only for external scripts.

I suppose some changes required, as we need special place to store updated internal scripts.

@johnd0e
Copy link
Contributor Author

johnd0e commented Feb 1, 2019

Currently plugins list (incl. metainfo) is hardcoded in apk..

So here is the list what should be done (IMHO, as I am not good in reading Java sources):

  • All scripts should be kept in some internal storage which does not demand storage permissions (like /sdcard/Android/data/org.exarhteam.iitc_mobile/assets/)
  • On apk install this directory should be emptied and refilled from apk content.
  • On iitc (re)load all the scripts should be (re)read (incl. metainfo).
  • There should be configurable update check for internal scripts.
    I suppose it's easy part, as we already have external scripts check.
  • We should also consider possibility to switch between update sources (like test/stable).

@johnd0e johnd0e added the help wanted Extra attention is needed label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed mobile
Projects
None yet
Development

No branches or pull requests

2 participants