Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File duplicates need removing #16

Open
roninsa opened this issue Jul 13, 2015 · 3 comments
Open

File duplicates need removing #16

roninsa opened this issue Jul 13, 2015 · 3 comments
Assignees

Comments

@roninsa
Copy link
Contributor

roninsa commented Jul 13, 2015

I found several duplicate files in the project that should probably be removed to avoid confusion.
There also is a sqlite db (image.db) file and a requirements.txt file that needs to be removed from flaskAPI/flickrAPI/. .gitignore probably needs to be modified to prevent any more sqlite db's from being placed in the repository.

duplicates: table_def.py, image_scrape.py

Just getting started and feeling like a noob so bear with me.

@roninsa roninsa self-assigned this Jul 14, 2015
@cgoodale
Copy link
Contributor

@roninsa don't worry about making the changes. There is a tagged release we can always use as a baseline. There is a lot of duplication of code, and I agree we need to add *.db to the .gitignore file for sure.

Thanks for taking up the torch on this effort, past few weeks at work and summer vacation have consumed all my time.

@roninsa
Copy link
Contributor Author

roninsa commented Jul 15, 2015

@cgoodale Okay, I'll be doing a pull request here pretty soon. In fact I plan on doing several over the next couple of days (if that's okay).

When I do, please look them over and let me know if there is something I missed or could do better.

My end plan is to have the project to a point where we can do a deployment on Heroku. I'm not sure I'll have that ready to demonstrate by next weeks meetup, but I should be able to show some progress by then.

I'm not sure what the protocol is. Should I merge my branch and commits on my end or should I let you do that on your end? Let me know.

Thanks!

@cgoodale
Copy link
Contributor

Hey @roninsa with the flexibility of Git, there are seemingly endless commit workflows to chose from. If you merge a branch locally into master, then once this repo merges the same Pull Request, then the repo's should be in-synch. Git is not my strong suit, so I am speculating here a bit.

I'll review the PR's and merge or comment on them as needed. Thanks for taking up the charge on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants