Skip to content

Commit 25f6ae5

Browse files
juwentus1234meta-codesync[bot]
authored andcommitted
fix: Update test method naming style in FilterToExpressionTest (facebookincubator#15554)
Summary: Pull Request resolved: facebookincubator#15554 Updated all test method names in FilterToExpressionTest.cpp to follow the proper coding style by starting with lowercase letters instead of uppercase. This brings the test naming convention in line with standard camelCase style used throughout the codebase. Reviewed By: mbasmanova, xiaoxmeng Differential Revision: D87371906 fbshipit-source-id: cd76ebf99a4b45915d38642747a45d25e4f2539a
1 parent b26ce23 commit 25f6ae5

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

velox/exec/tests/FilterToExpressionTest.cpp

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class FilterToExpressionTest : public testing::Test,
4545
}
4646
};
4747

48-
TEST_F(FilterToExpressionTest, AlwaysTrue) {
48+
TEST_F(FilterToExpressionTest, alwaysTrue) {
4949
auto filter = std::make_unique<common::AlwaysTrue>();
5050
auto expr = toExpr(filter.get(), BIGINT());
5151

@@ -57,7 +57,7 @@ TEST_F(FilterToExpressionTest, AlwaysTrue) {
5757
ASSERT_TRUE(constantExpr->value().value<TypeKind::BOOLEAN>());
5858
}
5959

60-
TEST_F(FilterToExpressionTest, AlwaysFalse) {
60+
TEST_F(FilterToExpressionTest, alwaysFalse) {
6161
auto filter = std::make_unique<common::AlwaysFalse>();
6262
auto expr = toExpr(filter.get(), BIGINT());
6363

@@ -69,7 +69,7 @@ TEST_F(FilterToExpressionTest, AlwaysFalse) {
6969
ASSERT_FALSE(constantExpr->value().value<TypeKind::BOOLEAN>());
7070
}
7171

72-
TEST_F(FilterToExpressionTest, IsNull) {
72+
TEST_F(FilterToExpressionTest, isNull) {
7373
auto filter = std::make_unique<common::IsNull>();
7474
auto expr = toExpr(filter.get(), BIGINT());
7575

@@ -78,7 +78,7 @@ TEST_F(FilterToExpressionTest, IsNull) {
7878
ASSERT_EQ(callExpr->inputs().size(), 1);
7979
}
8080

81-
TEST_F(FilterToExpressionTest, IsNotNull) {
81+
TEST_F(FilterToExpressionTest, isNotNull) {
8282
auto filter = std::make_unique<common::IsNotNull>();
8383
auto expr = toExpr(filter.get(), BIGINT());
8484

@@ -93,7 +93,7 @@ TEST_F(FilterToExpressionTest, IsNotNull) {
9393
ASSERT_EQ(isNullExpr->name(), "is_null");
9494
}
9595

96-
TEST_F(FilterToExpressionTest, BoolValue) {
96+
TEST_F(FilterToExpressionTest, boolValue) {
9797
auto filter = std::make_unique<common::BoolValue>(true, false);
9898
auto expr = toExpr(filter.get(), BOOLEAN());
9999

@@ -112,7 +112,7 @@ TEST_F(FilterToExpressionTest, BoolValue) {
112112
ASSERT_EQ(constantExpr->value().value<TypeKind::BOOLEAN>(), true);
113113
}
114114

115-
TEST_F(FilterToExpressionTest, BigintRangeSingleValue) {
115+
TEST_F(FilterToExpressionTest, bigintRangeSingleValue) {
116116
auto filter = std::make_unique<common::BigintRange>(42, 42, false);
117117
auto expr = toExpr(filter.get(), BIGINT());
118118

@@ -126,7 +126,7 @@ TEST_F(FilterToExpressionTest, BigintRangeSingleValue) {
126126
ASSERT_EQ(constantExpr->value().value<TypeKind::BIGINT>(), 42);
127127
}
128128

129-
TEST_F(FilterToExpressionTest, BigintRangeWithRange) {
129+
TEST_F(FilterToExpressionTest, bigintRangeWithRange) {
130130
auto filter = std::make_unique<common::BigintRange>(10, 20, false);
131131
auto expr = toExpr(filter.get(), BIGINT());
132132

@@ -145,7 +145,7 @@ TEST_F(FilterToExpressionTest, BigintRangeWithRange) {
145145
ASSERT_EQ(lessOrEqual->name(), "lte");
146146
}
147147

148-
TEST_F(FilterToExpressionTest, NegatedBigintRangeSingleValue) {
148+
TEST_F(FilterToExpressionTest, negatedBigintRangeSingleValue) {
149149
auto filter = std::make_unique<common::NegatedBigintRange>(42, 42, false);
150150
auto expr = toExpr(filter.get(), BIGINT());
151151

@@ -189,7 +189,7 @@ TEST_F(FilterToExpressionTest, NegatedBigintRangeSingleValue) {
189189
}
190190
}
191191

192-
TEST_F(FilterToExpressionTest, DoubleRange) {
192+
TEST_F(FilterToExpressionTest, doubleRange) {
193193
auto filter = std::make_unique<common::DoubleRange>(
194194
1.5, false, false, 3.5, false, false, false);
195195
auto expr = toExpr(filter.get(), DOUBLE());
@@ -209,7 +209,7 @@ TEST_F(FilterToExpressionTest, DoubleRange) {
209209
ASSERT_EQ(lessOrEqual->name(), "lte");
210210
}
211211

212-
TEST_F(FilterToExpressionTest, FloatRange) {
212+
TEST_F(FilterToExpressionTest, floatRange) {
213213
auto filter = std::make_unique<common::FloatRange>(
214214
1.5f, false, true, 3.5f, false, true, false);
215215
auto expr = toExpr(filter.get(), REAL());
@@ -229,7 +229,7 @@ TEST_F(FilterToExpressionTest, FloatRange) {
229229
ASSERT_EQ(lessThan->name(), "lt");
230230
}
231231

232-
TEST_F(FilterToExpressionTest, BytesRange) {
232+
TEST_F(FilterToExpressionTest, bytesRange) {
233233
auto filter = std::make_unique<common::BytesRange>(
234234
"apple", false, false, "orange", false, false, false);
235235
auto expr = toExpr(filter.get(), VARCHAR());
@@ -249,7 +249,7 @@ TEST_F(FilterToExpressionTest, BytesRange) {
249249
ASSERT_EQ(lessOrEqual->name(), "lte");
250250
}
251251

252-
TEST_F(FilterToExpressionTest, BigintValuesUsingHashTable) {
252+
TEST_F(FilterToExpressionTest, bigintValuesUsingHashTable) {
253253
std::vector<int64_t> values = {10, 20, 30};
254254
auto filter = common::createBigintValues(values, false);
255255
auto expr = toExpr(filter.get(), BIGINT());
@@ -280,7 +280,7 @@ TEST_F(FilterToExpressionTest, BigintValuesUsingHashTable) {
280280
ASSERT_EQ(arrayExpr->inputs().size(), 3);
281281
}
282282

283-
TEST_F(FilterToExpressionTest, BytesValues) {
283+
TEST_F(FilterToExpressionTest, bytesValues) {
284284
std::vector<std::string> values = {"apple", "banana", "orange"};
285285
auto filter = std::make_unique<common::BytesValues>(values, false);
286286
auto expr = toExpr(filter.get(), VARCHAR());
@@ -296,7 +296,7 @@ TEST_F(FilterToExpressionTest, BytesValues) {
296296
ASSERT_EQ(arrayExpr->inputs().size(), 3);
297297
}
298298

299-
TEST_F(FilterToExpressionTest, NegatedBytesValues) {
299+
TEST_F(FilterToExpressionTest, negatedBytesValues) {
300300
std::vector<std::string> values = {"apple", "banana", "orange"};
301301
auto filter = std::make_unique<common::NegatedBytesValues>(values, false);
302302
auto expr = toExpr(filter.get(), VARCHAR());
@@ -312,7 +312,7 @@ TEST_F(FilterToExpressionTest, NegatedBytesValues) {
312312
ASSERT_TRUE(containsExpr->name() == "in" || containsExpr->name() == "or");
313313
}
314314

315-
TEST_F(FilterToExpressionTest, NegatedBigintValuesUsingHashTable) {
315+
TEST_F(FilterToExpressionTest, negatedBigintValuesUsingHashTable) {
316316
std::vector<int64_t> values = {10, 20, 30};
317317
auto filter = std::make_unique<common::NegatedBigintValuesUsingHashTable>(
318318
10, 30, values, false);
@@ -343,7 +343,7 @@ TEST_F(FilterToExpressionTest, NegatedBigintValuesUsingHashTable) {
343343
ASSERT_EQ(isNullExpr->name(), "is_null");
344344
}
345345

346-
TEST_F(FilterToExpressionTest, TimestampRange) {
346+
TEST_F(FilterToExpressionTest, timestampRange) {
347347
auto timestamp1 = Timestamp::fromMillis(1609459200000); // 2021-01-01
348348
auto timestamp2 = Timestamp::fromMillis(1640995200000); // 2022-01-01
349349
auto filter =
@@ -365,7 +365,7 @@ TEST_F(FilterToExpressionTest, TimestampRange) {
365365
ASSERT_EQ(lessOrEqual->name(), "lte");
366366
}
367367

368-
TEST_F(FilterToExpressionTest, BigintMultiRange) {
368+
TEST_F(FilterToExpressionTest, bigintMultiRange) {
369369
std::vector<std::unique_ptr<common::BigintRange>> ranges;
370370
ranges.push_back(std::make_unique<common::BigintRange>(10, 20, false));
371371
ranges.push_back(std::make_unique<common::BigintRange>(30, 40, false));
@@ -378,7 +378,7 @@ TEST_F(FilterToExpressionTest, BigintMultiRange) {
378378
ASSERT_EQ(callExpr->inputs().size(), 2);
379379
}
380380

381-
TEST_F(FilterToExpressionTest, MultiRange) {
381+
TEST_F(FilterToExpressionTest, multiRange) {
382382
// Create a MultiRange filter with compatible filters for BIGINT field
383383
std::vector<std::unique_ptr<common::Filter>> filters;
384384

0 commit comments

Comments
 (0)