diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8f77bd938..c7cc1574d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ env: # Use the Go toolchain installed by setup-go GOTOOLCHAIN: local # renovate: datasource=github-releases depName=golangci/golangci-lint - GOLANGCI_LINT_VERSION: v2.5.0 + GOLANGCI_LINT_VERSION: v2.6.2 # renovate: datasource=github-releases depName=dominikh/go-tools STATICCHECK_VERSION: 2025.1.1 # renovate: datasource=github-releases depName=mfridman/tparse diff --git a/admin.go b/admin.go index 2568d14ce..a88fe6b06 100644 --- a/admin.go +++ b/admin.go @@ -82,6 +82,7 @@ type ClusterAdmin interface { // This operation is not transactional so it may succeed or fail. // If you attempt to add an ACL that duplicates an existing ACL, no error will be raised, but // no changes will be made. This operation is supported by brokers with version 0.11.0.0 or higher. + // // Deprecated: Use CreateACLs instead. CreateACL(resource Resource, acl Acl) error diff --git a/client_test.go b/client_test.go index 9d6242fa3..4ccf452b0 100644 --- a/client_test.go +++ b/client_test.go @@ -594,7 +594,7 @@ func TestClientRefreshBrokers(t *testing.T) { newSeedBrokers := []string{"localhost:12345"} _ = client.RefreshBrokers(newSeedBrokers) - if client.seedBrokers[0].addr != newSeedBrokers[0] { + if len(client.seedBrokers) == 0 || client.seedBrokers[0].addr != newSeedBrokers[0] { t.Error("Seed broker not updated") } if len(client.Brokers()) != 0 { diff --git a/config.go b/config.go index 5bac2b50a..80758e9bb 100644 --- a/config.go +++ b/config.go @@ -327,6 +327,7 @@ type Config struct { } Rebalance struct { // Strategy for allocating topic partitions to members. + // // Deprecated: Strategy exists for historical compatibility // and should not be used. Please use GroupStrategies. Strategy BalanceStrategy