Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] FDedup failing with latest release mmh3==5.1.0 #982

Open
1 of 2 tasks
touma-I opened this issue Jan 27, 2025 · 1 comment
Open
1 of 2 tasks

[Bug] FDedup failing with latest release mmh3==5.1.0 #982

touma-I opened this issue Jan 27, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@touma-I
Copy link
Collaborator

touma-I commented Jan 27, 2025

Search before asking

  • I searched the issues and found no similar issues.

Component

Transforms/universal/fdedup

What happened + What you expected to happen

When building the transform with current requirements.txt, we are pulling in the latest release of mmh3 that was published to pypi on Jan 25 and causing the UT of fdedup to fail.

Reproduction script

To produce the error, run test-src with mmh3>=4.1.0

To prevent the error, modify transforms/universal/fdedup/requirements.txt to add:
mmh3>=4.1.0, <=5.0.1

Anything else

Also investigate if relaxing polars can be achieved. It is currently set to polars==1.9.0 and the preferred approach would be to use polars>=1.9.0

OS

Ubuntu

Python

3.11.x

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@touma-I touma-I added the bug Something isn't working label Jan 27, 2025
@touma-I
Copy link
Collaborator Author

touma-I commented Jan 28, 2025

Stop gap in current dev branch: mmh3>=4.1.0, <=5.0.1

Long term, investigate how we can make it work for latest release of mmh3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants