Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fasttext==0.9.2 doesn't build/install with GCC v13 compiler #550

Closed
2 tasks done
sujee opened this issue Aug 27, 2024 · 3 comments
Closed
2 tasks done

[Bug] fasttext==0.9.2 doesn't build/install with GCC v13 compiler #550

sujee opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
bug Something isn't working fixed Marks an issues as fixed in the dev branch

Comments

@sujee
Copy link
Contributor

sujee commented Aug 27, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

Transforms/Other

What happened + What you expected to happen

pip install data-prep-toolkit-transforms-ray==0.2.1.dev1 fails on Ubuntu 24.04 with GCC compiler version 13

This is due to fasttext==0.9.2 dependency listed here : transforms/language/lang_id/python/pyproject.toml line 13

Reproduction script

Work-around 1 - Install and use GCC version 11

## These instructions are for Ubuntu 22.04 and later

sudo apt update

## install GCC/G++ compilers version 11 
sudo apt install -y gcc-11  g++-11

## Verify installation
gcc-11  --version
g++-11  --version
# should say 11

## Set the compiler before doing pip install
CC=gcc-11  pip install  data-prep-toolkit-transforms-ray==0.2.1.dev1

Fix 2 : upgrade to fasttext 0.9.3 (latest)

Update it here : transforms/language/lang_id/python/pyproject.toml line 13

This compiles and installs cleanly. Need to make sure the version upgrade doesn't introduce any other issues.

Anything else

No response

OS

Ubuntu

Python

3.11.x

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@sujee sujee added the bug Something isn't working label Aug 27, 2024
@sujee sujee changed the title [Bug] fasttext==0.9.2 doesn't build/install with latest GCC compiler [Bug] fasttext==0.9.2 doesn't build/install with GCC v13 compiler Aug 27, 2024
@Bytes-Explorer
Copy link
Collaborator

Thanks for raising this. I think this is getting addressed in this PR #545 (comment) cc @touma-I

@daw3rd
Copy link
Member

daw3rd commented Sep 12, 2024

@sujee can you confirm the fix? Thanks.

@daw3rd daw3rd added the fixed Marks an issues as fixed in the dev branch label Sep 12, 2024
@sujee
Copy link
Contributor Author

sujee commented Sep 13, 2024

confirming fix . closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Marks an issues as fixed in the dev branch
Projects
None yet
Development

No branches or pull requests

5 participants