Skip to content

fix(vllm_performance): improve error handling #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 13, 2025
Merged

fix(vllm_performance): improve error handling #218

merged 6 commits into from
Nov 13, 2025

Conversation

@christian-pinto
Copy link
Member

@christian-pinto christian-pinto commented Nov 13, 2025

This PR improves:

  • Ray exception handling in run-experiments
  • Errors handling for Kubernetes objects manager in vllm_perf actuator

michael-johnston and others added 5 commits November 13, 2025 14:18
@michael-johnston
chore(vllm_perf): additional warning log
e56434d
@michael-johnston
docs(vllm_perf): add missing required field
70c6464
@michael-johnston
feat(core): improve run_experiment error handling
6fb3386 
- Wait actuators ready
- Install Resource Cleaner
- Catch correct exception on submit
- Wait on submit response
- Shutdown at end to ensure cleanup of ray actors etc.
@michael-johnston
chore(cleanup): logging
e6badf7
@christian-pinto
chore(vllm-perf): Improved error handling for kubernetes objects manager
a25d082 
Signed-off-by: Christian Pinto <[email protected]>
@DRL-NextGen
Copy link
Member

DRL-NextGen commented Nov 13, 2025 •
edited
Loading

No vulnerabilities found.

@michael-johnston michael-johnston changed the title chore(core, vllm perf): Improved error handling in run_experiment script and vllm_perf actuator feat(vllm_perf,core): Improved error handling in run_experiment script and vllm_perf actuator Nov 13, 2025
@DRL-NextGen
Copy link
Member

DRL-NextGen commented Nov 13, 2025

Checks Summary

Last run: 2025-11-13T16:42:56.744Z

Code Risk Analyzer vulnerability scan found 2 vulnerabilities:

Severity Identifier Package Details Fix
🔷Medium CVE-2025-50181 urllib3
urllib3 redirects are not disabled when retries are disabled on PoolManager instantiationGHSA-pq67-6m6q-mj2v

urllib3:2.3.0->kubernetes:34.1.0
 2.5.0
🔷Medium CVE-2025-50182 urllib3
urllib3 does not control redirects in browsers and Node.jsGHSA-48p4-8xcf-vxj5

urllib3:2.3.0->kubernetes:34.1.0
 2.5.0

@AlessandroPomponio AlessandroPomponio changed the title feat(vllm_perf,core): Improved error handling in run_experiment script and vllm_perf actuator fix(vllm_performance): improve error handling Nov 13, 2025
@michael-johnston michael-johnston added this pull request to the merge queue Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 13, 2025
@michael-johnston michael-johnston added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 3262f04 Nov 13, 2025
18 checks passed
@michael-johnston michael-johnston deleted the maj_vllm_perf_fix branch November 13, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlessandroPomponio AlessandroPomponio AlessandroPomponio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christian-pinto @DRL-NextGen @AlessandroPomponio @michael-johnston