Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar SignUp and Logo issue solved #563

Merged
merged 6 commits into from
Dec 25, 2022
Merged

Navbar SignUp and Logo issue solved #563

merged 6 commits into from
Dec 25, 2022

Conversation

AbhiPatel10
Copy link
Contributor

Fixes Issue

**My PR closes #562 **
**My PR closes #560 **

Changes proposed

What were you told to do ?

What did you do ?

Sign Up Button render Before Contact Us page so I Solved That issue.

Clicking on logo is re load the Entire page so i solved that issue.


Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Screenshots

image

AbhiPatel10 and others added 4 commits December 18, 2022 00:39
Two Navbar shows in Some pages so remove in all pages and only one navbar is app.jsx file
Sign Up Button render Before Contact Us page so I Solved That issue.

Clicking on logo is re load the Entire page so i solved that issue.
@vercel
Copy link

vercel bot commented Dec 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
milan ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 22, 2022 at 7:41PM (UTC)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello contributor, thank you for opening a Pull Request 🎉.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out Tamal Das on Twitter.
Star ⭐ this repo to show us support.

Happy, Open Source!

@vercel vercel bot temporarily deployed to Preview December 20, 2022 17:15 Inactive
@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. 🟧 priority: high area/ui This issue is related to frontend/interface fix. 🐞 bug This is a patch, generally fixing some bugs. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Dec 22, 2022
@vercel vercel bot temporarily deployed to Preview December 22, 2022 15:53 Inactive
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks great however we might wanna fix this:

image

Whenever we hover there's a difference in background color of the button, maybe we can fix this

@vercel vercel bot temporarily deployed to Preview December 22, 2022 19:41 Inactive
@AbhiPatel10
Copy link
Contributor Author

Done Done, I change what you say above. and also add responsive in Navbar.

@AbhiPatel10
Copy link
Contributor Author

Please accept the PR if everything is good.

@tamalCodes tamalCodes merged commit a3542b1 into ngoworldcommunity:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. area/ui This issue is related to frontend/interface fix. 🐞 bug This is a patch, generally fixing some bugs. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
None yet
3 participants