-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install failing on Ruby 3.3.0 and Heroku #20
Comments
+1 on Render. Seems like |
I ran into this on another gem migrating to 3.3.0. The One thing to note: I needed to add |
I guess that means #21 fixes this? |
Having the same issue with installing for Ruby 3.3.0 on bullseye - build is fine until I try to add the gem:
|
From what I've noticed, the gem is not trying to build on Ruby 3.2 which tells me there's already a valid binary version in the RubyGems for that. Would be great if we could have a prebuilt one for 3.3 in there as well as this is also a blocker for us |
Looking at the code, it looks like pushing a new version will trigger the cross-compile-action, which will compile the gem for these platforms and these Ruby-versions, as can be seen in this build for the current version. Ruby 3.3 was not released when the current version of this gem was released, hence there is no precompiled version for Ruby 3.3. Tldr; Releasing a new version should solve this issue. |
Unfortunately version 0.0.7 of the gem does not include binaries in rubygems as the build process has failed - https://github.com/IAPark/tiktoken_ruby/actions/runs/7868320647 FYI @IAPark |
I took a shot at fixing that the other day in my fork.
I couldn't pull the rbsys container locally or the latest
But the tags seem to be available on dockerhub. Ah, this issue seems to be a resolution? oxidize-rb/rb-sys#324. @IAPark I got my fork to cross-compile successfully now that the docker containers are in place. Should work here just by re-running the action. |
Latest release (0.0.7) now has the compiled binaries and worked on my heroku deploy. Please re-open if not resolved for you. |
@ScotterC I'm seeing the following installing the Gem for Ruby 3.2.3, inside a Debian Bulleye Docker container, running on an Arm Mac.
Additionally, when trying to build a Ruby 3.2.2 container and install this Gem, i see the following:
Are there any new steps that need to be taken before this uses the compiled binaries? |
@prdanelli hmm AFAIK there's nothing else that should be needed to use the compiled binaries so I'm confused by the errors you're getting. The only thing that stands out to me is |
On my end I confirm that 0.0.7 deployed on Heroku without clang, decreasing our slug size by ~110MB. Thank you!! |
@bmulholland , I'm struggling to deploy 0.0.7 on Heroku without clang. Both on Ruby 3.3 and 3.2.2. Not sure there are any particular steps I've missed? |
It was always installing fine on 3.2.2 so you’ve got a different issue than this one. Check your build logs and work through it from there. |
I am using Ruby
3.3.0-rc1
, it works great with v3.2.2Error....
The text was updated successfully, but these errors were encountered: