-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Riven v0.12+ breaking changes required deleting settings and database (Previously: Torrentio is broken #55
Comments
You know what Profucius says? "You fix a man's bugs, he's good for a day. You teach a man to fix bugs, he's good for a lifetime" Ok, bad jokes aside. Can you send me a list of the DMB and Riven settings you had enabled; I'll see if I can replicate the bug. |
You got me there haha! Although normally I am adept at handling bugs, but with the combination of being newish with docker, and Riven making deep changes, I'm a bit turned around here. I've attached the config files via a zip file in the link below, figured that is easier. Thanks for taking a look. btw if you need to swap in your tokens for testing, I replaced them all with "redacted". |
Thanks for the additional info. I've tried replicating the bug, but I have been unsuccessful. Is the bug consistently occurring? |
Same issue for me. In fact, even after disabling torrentio manually from riven’s json settings, I get the same issue on startup and everything will eventually shut down - I’m not quite sure how to restore functionality. I also tried a hard reset of Riven’s DB, but no luck. |
This shouldn't be happening to you. I'm able to reverse it and get back into Riven again by simply changing this line to false in the Riven
|
Try deleting the Riven/data/alembic directory and restarting. |
As a last option, try deleting the PostgreSQL data directory and restarting. |
I tried this and it did not work.
Then I tried this, and it worked! Torrentio enabled successfully and Riven continued running. The downside is that I lost everything in the Library tab that Riven was tracking, but honestly that is a sacrifice I'm willing to make to get it running again. Any idea how this might've happened? I'm currently assuming something went wrong with the recent Riven major changes. Also is this technically a DMB issue or is it a Riven issue? I'm considering updating my original ticket on the Riven repo. |
It was likely due to the Riven update that required the database to be reset; new states were added. |
Something's even more odd on my side.
Relevant part of the logs, for reference:
And this is the relevant part of my docker compose:
|
Interesting, I have painfully come to realize how huge of a change this Riven update was after all this. They said they'd announced it on their Discord, but I wasn't a member of it yet, but even if I had been I didn't see where they had used Would it be possible for you to reflect such major changes onto your github releases page too? The extra visibility would help prevent some potential catastrophes in the future, especially to those who have installed DMB but aren't following the original devs/discords. One last question, is it possible to disable DMB from auto-updating all the contained softwares on every release? I'm currently assuming I just need to hardcode the version in the docker compose file for any software I don't want to update. I might do that in Riven for the time being so that I can have a break from this. |
I seem to remember seeing this during my testing. Try renaming your Riven @NoSync I believe you should open a separate ticket for this, it appears to be a different issue at this point. |
Riven's breaking changes have been the bane of existence! I've requested the same. They use Semantic Versioning, as do I; however, Riven has not incremented the MAJOR field on a breaking change. As for tracking it on the DMB repo, that's a bit difficult to do when no changes are required for the DMB code to support a Riven breaking change - where typically the indicator would be the MAJOR field for the DMB version. |
Try the below; just cleaned it up a bit:
|
I see, yes that is quite maddening isn't it. I've talked to other devs in the past about versioning, sometimes they can be staunch about it and it makes little sense to me why not just increment a major version, that's what it's for. Well I just want to say I appreciate you keeping things straight for us here on this repo! And thanks a ton for your diagnostics to help me resolve this issue too. Edit: Just answered my own question about the frontend/backend versions. Found them in the Riven>About page. 👍 |
It was indeed a case of two separate issues caused by the latest riven update, one of them being the one mentioned in this ticket. On one hand, the settings.json I had was no longer playing nice with the latest riven version. After I removed it, as you recommended, I got the same crashes as per OP when restoring my pgsql data directory, which were solved by zapping the data directory again. In short, should anybody else stumble upon this, to get everything to work nicely with the latest release both settings.json and the DB data had to be initialized from scratch. I also cleaned up the logging vars in my docker-compose a little, as suggested by @I-am-PUID-0, although they weren't the culprits. Thanks to both. |
Glad you got it working! A cautionary tale to all: Riven is under heavy development. If they anounce major breaking changes, we should be prepared to delete (or use a file diff app to compare) the Thanks to PUID as always for being patient with us AND with the Riven devs haha. Much love to all. |
New bug after closing #54 . I opened a ticket on the Riven repo directly for this one, and they referred me back to you/DMB again.
rivenmedia/riven#722
Essentially the issue is that when I enable Torrentio in Riven settings, it crashes the Riven backend. Then when I restart the stack, it cannot load at all, and shuts down. When I asked for help, they said something about needing a host/port for it? I'm a bit confused.
I can modify and save other settings successfully, but when I enable Torrentio and save, this crashes.
The text was updated successfully, but these errors were encountered: