Update homepage to not used wagtail pages #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frjo
requested changes
Sep 12, 2024
|
|
||
|
|
||
| class ApplyHomePage(Page): | ||
| # Only allow creating HomePages at the root level | ||
| parent_page_types = ["wagtailcore.Page"] | ||
| subpage_types = ["funds.FundType", "funds.LabType", "funds.RequestForPartners"] | ||
|
|
||
| strapline = models.CharField(blank=True, max_length=255) |
There was a problem hiding this comment.
Removing this line makes the code in copy_homepage_title_and_strapline not run since the model no longer have a strapline.
Would be really good to get this working making the deployment of this release seamless.
Maybe we can remove the strapline field in a separate release?
There was a problem hiding this comment.
Right, hasattr will always be false. I think we can remove it later after couple of releases.
There was a problem hiding this comment.
Updated the code so that it keeps the strapline on the ApplyHome model.
theskumar
force-pushed
the
homepage-settings
branch
from
ed90f14
to
b3fd203
Compare
theskumar
force-pushed
the
homepage-settings
branch
from
b3fd203
to
4685820
Compare
frjo
approved these changes
Sep 26, 2024
frjo
added
Status: Needs testing
wes-otf
approved these changes
Oct 17, 2024
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
sandeepsajan0
pushed a commit
that referenced
this pull request
Oct 18, 2024
Use standard django views to show hompeage instead of piggy backing on the wagtail. This allows to remove the "Pages" menu from the wagtail admin and have the homepage settings be at a single "System Settings" - update the hompeage to use Settings > System Settings - add data migration to move the properties from ApplyHompeage model to SystemSettings - hide "Pages" menu from wagtail - Refractor the homepage template Fixes: #4116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use standard django views to show hompeage instead of piggy backing on
the wagtail. This allows to remove the "Pages" menu from the wagtail
admin and have the homepage settings be at a single "System Settings"
SystemSettings
Fixes: #4116