Staff role should not suppress reviewer emails #3984
Conversation
Reviewer email notification for assigned application behavior corrected. Fixes #3983
bickelj
changed the title
|
We need some way to configure this. OTF uses Slack and their staff do not want duplicate info via e-mail. I'm thinking a settings |
|
@frjo That sounds simple enough. But then looking under the hood, it is not obvious if/where we track state of "I sent X type of message or not" so this might be more work than it seems. |
|
@bickelj All notifications to staff are sent via Slack currently. That is the reason for We plan, hopefully this year, to make all notifications go via e-mail as default. Staff notifications via Slack will be optional then. If you think it is worthwhile you can implement the setting for this particular case. But might be best/easiest to wait for us fixing it for all notifications. |
|
@frjo Since this is a one-line merge conflict, I think we can leave this alone for now. I was trying to think of a durable, better, more general way of honoring such a setting but it eluded me. My best thought was something like "pass the list of enabled messengers in kwargs to every messenger" and/or "pass the list of already-processed messengers in kwargs to every next messenger" but any actions taken on those would be under the assumption that the list is in priority order, which is flimsy. |
Reviewer email notification for assigned application behavior corrected.
Fixes #3983
Test Steps
Set up a dummy email SMTP server or use file-based email.