-
Notifications
You must be signed in to change notification settings - Fork 6
Add custom fields and creating/updating test cases with custom fields #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ramilamparo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement by integrating custom field management into the system. It provides a new API tool to fetch project-specific custom fields and extends the existing test case management to allow for the creation and updating of test cases with these custom field values. This change aims to provide greater flexibility and extensibility for test case metadata, enabling users to tailor test case information to their unique requirements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces functionality for handling custom fields. A new tool list_custom_fields is added to fetch custom fields for a project. The create_test_case and update_test_case tools are updated to support setting custom field values. The changes are well-structured. I've provided a few suggestions to improve error handling, API usability, and schema robustness.
| requirements?: UpdateTestCaseRequirement[] // Optional: Test case requirements | ||
| links?: UpdateTestCaseLink[] // Optional: Additional links relevant to the test case | ||
| customFields?: { [key: string]: UpdateTestCaseCustomField } // Optional: Custom field values | ||
| customFields?: { [key: string]: TestCaseCustomFieldValue } // Optional: Custom field values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question - how does AI infer that the key should be the system name ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In zod schema, there is information about it
.describe(
'Custom field values. Use the systemName property from custom fields as the key. Only enabled fields should be used. Use list_custom_fields tool to get the custom fields.'
)
but I am not sure if this information reaches the AI agent.
https://github.com/Hypersequent/tms-issues/issues/2061