magento#271: [My Account] Attributes validation: parameter missing in request fix

furseyev · furseyev · commit 2eb7c155b1ec · 2019-06-25T10:16:01.000+03:00
diff --git a/app/code/Magento/CustomerGraphQl/Model/Customer/ValidateCustomerData.php b/app/code/Magento/CustomerGraphQl/Model/Customer/ValidateCustomerData.php
@@ -47,7 +47,10 @@ public function execute(array $customerData, $addRequiredAttributes = false): vo
         $errorInput = [];
 
         foreach ($attributes as $attributeInfo) {
-            if ($attributeInfo->getIsRequired() && $customerData[$attributeInfo->getAttributeCode()] == '') {
+            if ($attributeInfo->getIsRequired()
+                && (!isset($customerData[$attributeInfo->getAttributeCode()])
+                    || $customerData[$attributeInfo->getAttributeCode()] == '')
+            ) {
                 $errorInput[] = $attributeInfo->getDefaultFrontendLabel();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,10 @@ public function execute(array $customerData, $addRequiredAttributes = false): vo`
`47`	`47`	`$errorInput = [];`
`48`	`48`
`49`	`49`	`foreach ($attributes as $attributeInfo) {`
`50`		`- if ($attributeInfo->getIsRequired() && $customerData[$attributeInfo->getAttributeCode()] == '') {`
	`50`	`+ if ($attributeInfo->getIsRequired()`
	`51`	`+ && (!isset($customerData[$attributeInfo->getAttributeCode()])`
	`52`	`+ \|\| $customerData[$attributeInfo->getAttributeCode()] == '')`
	`53`	`+ ) {`
`51`	`54`	`$errorInput[] = $attributeInfo->getDefaultFrontendLabel();`
`52`	`55`	`}`
`53`	`56`	`}`