Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably don't need an intermediary type for serialization #29

Open
HyperCodec opened this issue Feb 29, 2024 · 2 comments
Open

Probably don't need an intermediary type for serialization #29

HyperCodec opened this issue Feb 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@HyperCodec
Copy link
Owner

The NNTSerde struct makes it easier to write because of the derive macro, but it is also a lot slower than just converting directly from the neural network topology.

@HyperCodec HyperCodec added the enhancement New feature or request label Feb 29, 2024
@HyperCodec HyperCodec self-assigned this Feb 29, 2024
@HyperCodec
Copy link
Owner Author

HyperCodec commented Feb 29, 2024

The best solution for this would be to fix the Arc<RwLock> spam, although this may introduce a ton of complexity in the diversity between with and without the rayon feature

@HyperCodec
Copy link
Owner Author

If #60 does end up rewriting everything without Arc spam, this will become significantly easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant