Skip to content

Commit 3e7bba4

Browse files
authored
Cleanup phase failed when using the same image for multiple components due to a failure in removing the image (#22)
more than once. To fix this - ignored that specific issue "reference does not exist" when that error is returned from the docker remove request
1 parent a70935a commit 3e7bba4

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [0.0.9](https://github.com/PerimeterX/envite/compare/v0.0.8...v0.0.9)
9+
10+
### Fixed
11+
12+
- Cleanup phase failed when using the same image for multiple components due to a failure in removing the image
13+
more than once. To fix this - ignored that specific issue "reference does not exist" when that error is returned
14+
from the docker remove request
15+
816
## [0.0.8](https://github.com/PerimeterX/envite/compare/v0.0.7...v0.0.8)
917

1018
### Added

docker/component.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ func (c *Component) Cleanup(ctx context.Context) error {
255255

256256
func (c *Component) removeImage(ctx context.Context) error {
257257
_, err := c.cli.ImageRemove(ctx, c.imageCloneTag, image.RemoveOptions{})
258-
if err != nil {
258+
if err != nil && !strings.Contains(err.Error(), "reference does not exist") {
259259
return err
260260
}
261261

0 commit comments

Comments
 (0)