Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there is not transcript, there should not be a transcript element added to to the embed #8

Open
Hpmason opened this issue Feb 24, 2022 · 0 comments
Labels
bug Something isn't working testing-required Not enough info, so more testing is needed

Comments

@Hpmason
Copy link
Owner

Hpmason commented Feb 24, 2022

Currently if there is a comic with an empty string transcript, the transcript element should not be added.

Json data:

{
    "month": "1",
    "num": 1782,
    "link": "",
    "year": "2017",
    "news": "",
    "safe_title": "Team Chat",
    "transcript": "",
    "alt": "2078: He announces that he's finally making the jump from screen+irssi to tmux+weechat.",
    "img": "https://imgs.xkcd.com/comics/team_chat.png",
    "title": "Team Chat",
    "day": "6"
}

Bug most likely occurs from this line:

if self.transcript.is_empty() {

This would fail if there was whitespace added at some point during de-serialization, so requires some testing

@Hpmason Hpmason added bug Something isn't working testing-required Not enough info, so more testing is needed labels Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing-required Not enough info, so more testing is needed
Projects
None yet
Development

No branches or pull requests

1 participant