Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Previous errors are showing up in lab request screen #2260

Closed
jackcmeyer opened this issue Jul 29, 2020 · 3 comments · Fixed by #2268
Closed

Previous errors are showing up in lab request screen #2260

jackcmeyer opened this issue Jul 29, 2020 · 3 comments · Fixed by #2268
Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Milestone

Comments

@jackcmeyer
Copy link
Member

🐛 Bug Report

When creating a new lab request, if I request lab and it fails the validation and provides error feedback to the user, and then leave the page, and then come back, the previous errors are still on the page.

To Reproduce

  1. Navigate to new lab request
  2. Click the save button
  3. see the validation errors
  4. navigate to anywhere else in the system
  5. navigate back to the new lab request screen
  6. see that the errors are still present.

Expected behavior

The errors should no longer show when I navigate back to the lab request page.

@jackcmeyer jackcmeyer added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions good first issue indicates an issue is good for a first time contributor labs issue/pull request that interacts with labs module LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) labels Jul 29, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Jul 29, 2020
@Tomastomaslol
Copy link
Contributor

Hi @jackcmeyer, I think I should be able to help you with this issue. Could you please assign it to me?

@jackcmeyer
Copy link
Member Author

@Tomastomaslol I've assigned this to you

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Jul 31, 2020
@Tomastomaslol
Copy link
Contributor

Hi @jackcmeyer,

I noticed a similar issue when creating a new patient.

Kapture 2020-08-01 at 14 37 21

Are you happy for me to report it as an issue and suggest a fix for it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Projects
None yet
2 participants