Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(navbar): Make Navbar mobile-friendly #2118

Merged
merged 8 commits into from Jun 8, 2020
Merged

fix(navbar): Make Navbar mobile-friendly #2118

merged 8 commits into from Jun 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 5, 2020

Fixes #2117.

Changes proposed in this pull request:

  • Navbar becomes bare minimum when Sidebar goes away at a certain browser width.
  • Add a hamberger menu for the bare minimum version, with the same menu items as the Sidebar.

Please note:
Some updates are wanted in the Components repo later.

  • Link list can display an icon and a text
  • Link list can show a divider
  • Use Font Awesome's bars icon

@gitpod-io
Copy link

gitpod-io bot commented Jun 5, 2020

@vercel
Copy link

vercel bot commented Jun 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/g2ghyxj7z
✅ Preview: https://hospitalrun-frontend-git-fork-kumikokashii-mobile-navbar.hospitalrun.now.sh

@ghost ghost mentioned this pull request Jun 5, 2020
@matteovivona matteovivona requested a review from jackcmeyer June 5, 2020 09:44
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Jun 5, 2020
@matteovivona matteovivona self-requested a review June 5, 2020 09:44
Copy link
Contributor

@matteovivona matteovivona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh I don't see bars icon. I've tried both on Safari iOS, Safari macOS and Firefox.

@ghost
Copy link
Author

ghost commented Jun 5, 2020

Mmh I don't see bars icon. I've tried both on Safari iOS, Safari macOS and Firefox.

@tehkapa Yes, currently, it's only displaying the downward arrow at very left of the navbar. Please click on the arrow to open up the dropdown menu.

Some updates are wanted in the Components repo later:

  • Link list can display an icon and a text
  • Link list can show a divider
  • Use Font Awesome's bars icon

@matteovivona matteovivona self-requested a review June 5, 2020 15:41
@vercel vercel bot temporarily deployed to Preview June 7, 2020 18:46 Inactive
@jackcmeyer jackcmeyer merged commit 391271a into HospitalRun:master Jun 8, 2020
@jackcmeyer jackcmeyer added the 🚀enhancement an issue/pull request that adds a feature to the application label Jun 8, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Jun 8, 2020
@ghost ghost deleted the mobile-navbar branch June 17, 2020 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Navbar mobile friendly
2 participants