This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
feat(labs): ability to filter by status on labs screen #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new slice for labs, from there are made queries referring to labs, including search functionalities. Fixed a very small bug on the sidebar, and also added english translation variables for the new components. fix HospitalRun#1971
…into feature/ability-to-filter-by-status-on-labs-screen
…into feature/ability-to-filter-by-status-on-labs-screen
…into feature/ability-to-filter-by-status-on-labs-screen
Modified the Repository, added a mapping function to add an index for each sort field required. Tests were failing due to the lack of index when sorting fix HospitalRun#1971
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/58yth7bb8 |
|
|
|
Hey guys, could you please review?, thanks! @jackcmeyer @fox1t |
jackcmeyer
added
labs
jackcmeyer
suggested changes
May 1, 2020
matteovivona
added
the
in progress
Suggested changes according to PR HospitalRun#2033 were added fix HospitalRun#1971
Pulled changes from upstream fix HospitalRun#1971
Improved search process by adding code search criteria to the pouchdb query fix HospitalRun#1971
Added a test to prove search labs by code functionality fix HospitalRun#1971
matteovivona
approved these changes
May 6, 2020
jackcmeyer
changed the title
jackcmeyer
approved these changes
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1971.
Changes proposed in this pull request:
Repositoryfile in order to modify the functionfindAll, adding a mapping iterator to create indexes for each field of the SortRequest parameter sent in.